Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: bump sbt to 1.8.0 #241

Merged
merged 1 commit into from
Nov 15, 2022
Merged

deps: bump sbt to 1.8.0 #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .scala-steward.conf
View file
Open in desktop

This file was deleted.

5 changes: 4 additions & 1 deletion build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,10 @@ lazy val plugin = project
"org.scalameta" %% "scalafmt-dynamic" % scalafmtVersion
),
scriptedBufferLog := false,
scriptedLaunchOpts += s"-Dplugin.version=${version.value}"
scriptedLaunchOpts += s"-Dplugin.version=${version.value}",
// For compat reasons we have this in here to ensure we are testing against 1.2.8
// We honestly probably don't need to, so if this ever causes issues, rip it out.
pluginCrossBuild / sbtVersion := "1.2.8"
)

// For some reason, it doesn't work if this is defined in globalSettings in PublishPlugin.
Expand Down
2 changes: 1 addition & 1 deletion project/build.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.2.8
sbt.version=1.8.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ckipp01 will that mean users of this plugin will have to upgrade their sbt to this version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it doesn't. Since I'm using pluginCrossBuild / sbtVersion := "1.2.8" it ensures that it's still compiling and testing against "1.2.8" even though the build itself is managed with 1.8.0.

You can see some more details about this in https://www.scala-sbt.org/1.x/docs/Plugins.html#Creating+an+auto+plugin.