Filter out non-identifiers from $data before calling find() #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @guilhermeblanco |
|
Is this really required? I don't think it's necessary unless it creates partial proxy objects. |
|
|
||
| // Exclude non-identifiers | ||
| $filteredIdentifierList = array(); | ||
| foreach ($data as $identifier => $value) { |
… initialize proxy object. (cleanup and optimizations per review; rebased)
schmittjoh
added a commit
that referenced
this pull request
Dec 4, 2012
Filter out non-identifiers from $data before calling find()
|
Thanks for the optimization and quick turnaround on this PR! |
| $identifierList = array(); | ||
|
|
||
| foreach ($classMetadata->getIdentifierFieldNames() as $name) { | ||
| if ( ! isset($data[$name])) { |
There was a problem hiding this comment.
This is wrong. isset returns false if you have the key but value is null.
Null values are accepted as part of composite PKs, so this needs to be addressed here.
To correctly fix the issue, change the method to array_key_exists.
There was a problem hiding this comment.
I'll open a new PR. It feels like something was missed when cherry picking from schmittjoh/JMSSerializerBundle#222.
|
See PR2. Everything else seems ok. Thanks. |
schmittjoh
pushed a commit
that referenced
this pull request
Jan 6, 2015
bassrock
pushed a commit
to Klinche/serializer
that referenced
this pull request
Mar 26, 2016
Removed unnecessary namespace duplication
alcalyn
pushed a commit
to alcalyn/serializer
that referenced
this pull request
May 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and then initialize proxy object.