C++ refactoring: Implementing _localindex. #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…d IndexedOption Array
for more information, see https://pre-commit.ci
…hep/awkward-1.0 into stormiestsin/refactoring
for more information, see https://pre-commit.ci
jpivarski
approved these changes
Aug 23, 2021
There was a problem hiding this comment.
Great! I just made some minor tweaks. (We talked on Slack.)
This dovetails well with #1036, which defines compact_offsets64 on RegularArray only; this PR defines it on ListArray and ListOffsetArray. This (and broadcast_tooffsets64) will be hidden with underscores.
Unless you have any last commits, I'll merge it after the tests pass. Thanks!
67 tasks
|
Yup, you can merge it, I don't have any other additions. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
_localindexfunction for all the Awkward Array types exceptVirtualArray._localindeximplementation_localindextests