Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++ refactoring: Implementing _localindex. #1059

Merged
merged 26 commits into from
Aug 23, 2021
Merged

C++ refactoring: Implementing _localindex. #1059

merged 26 commits into from
Aug 23, 2021

Commits on Aug 12, 2021

  1. Added stubs for localindex

    stormiestsin committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    9387b41 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2021

  1. Implemented NumpyArray, EmptyArray and RegularArray localindex

    stormiestsin committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    29bfce1 View commit details
    Browse the repository at this point in the history

  2. Completed implementation of _axis_wrap_if_negative

    stormiestsin committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    53f106b View commit details
    Browse the repository at this point in the history

  3. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    64d61a7 View commit details
    Browse the repository at this point in the history

  4. Run black reformatter

    stormiestsin committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    61a13a2 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2021

  1. Fix Bugs in the implementation of localindex of Regular and NumpyArray

    stormiestsin committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    e09172e View commit details
    Browse the repository at this point in the history

  2. Fixed conflict in RegularArray localindex

    stormiestsin committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    19ca1ce View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2021

  1. Added localindex implementation for BitMasked, ByteMasked, Indexed an… 

    …d IndexedOption Array
    stormiestsin committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    eb30c88 View commit details
    Browse the repository at this point in the history

  2. Finish up implementing localindex for rest of the types

    stormiestsin committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    711f683 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2021

  1. [skip ci] Add localindex wrapper to all classes

    stormiestsin committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    c8d310e View commit details
    Browse the repository at this point in the history

  2. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    41f853c View commit details
    Browse the repository at this point in the history

  3. Added an example test

    stormiestsin committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    d1c3acb View commit details
    Browse the repository at this point in the history

  4. Added tests for Regular, Bytemasked and ListOffsetArray

    stormiestsin committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    1d3ddb3 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'stormiestsin/refactoring' of https://github.com/scikit-… 

    …hep/awkward-1.0 into stormiestsin/refactoring
    stormiestsin committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    a7f339f View commit details
    Browse the repository at this point in the history

  6. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    2064490 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2021

  1. Added all the remaining tests

    stormiestsin committed Aug 21, 2021
    Configuration menu
    Copy the full SHA
    baf6e2a View commit details
    Browse the repository at this point in the history

  2. Reformatter

    stormiestsin committed Aug 21, 2021
    Configuration menu
    Copy the full SHA
    5fc99d1 View commit details
    Browse the repository at this point in the history

  3. Merged and resolved conflicts

    stormiestsin committed Aug 21, 2021
    Configuration menu
    Copy the full SHA
    7e1fdc9 View commit details
    Browse the repository at this point in the history

  4. Fixed flake8 errors

    stormiestsin committed Aug 21, 2021
    Configuration menu
    Copy the full SHA
    9f48f94 View commit details
    Browse the repository at this point in the history

  5. Fixed TODOs. Ready for review

    stormiestsin committed Aug 21, 2021
    Configuration menu
    Copy the full SHA
    866964a View commit details
    Browse the repository at this point in the history

  6. Removed duplicate kernel wrappers

    stormiestsin committed Aug 21, 2021
    Configuration menu
    Copy the full SHA
    c96827f View commit details
    Browse the repository at this point in the history

  7. Fix a wrong kernel invocation

    stormiestsin committed Aug 21, 2021
    Configuration menu
    Copy the full SHA
    8d72913 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2021

  1. Removed v1 references while asserting

    stormiestsin committed Aug 22, 2021
    Configuration menu
    Copy the full SHA
    10807bc View commit details
    Browse the repository at this point in the history

  2. v1 arrays double checked if used for asserting

    stormiestsin committed Aug 22, 2021
    Configuration menu
    Copy the full SHA
    e69b081 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2021

  1. Just some tweaks.

    @jpivarski
    jpivarski committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    75cb300 View commit details
    Browse the repository at this point in the history

  2. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    7544195 View commit details
    Browse the repository at this point in the history