-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C++ refactoring: ak.full_like, ak.zeros_like, ak.ones_like #1293
Conversation
Codecov Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one request to loosen the allowed inputs for dtype
, then (with a test), you can merge it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We talked about three changes in Slack,
- use
fill_value = nplike.array([fill_value], dtype=dtype)[0]
so that dates get the right granularity dtype == np.dtype(np.bool_)
instead ofdtype is bool
fill_value.view(np.uint8)
in the boolean case (or should it benp.int8
? maybe it doesn't matter) so thatfill_value
always has a NumPy type and not a Python type.
When those are done, you can squash and merge!
No description provided.