fix: issue with inResource meta file not copied for corner cases (#179)

* fix: issue with inResource meta file not copied for corner cases

* perf: do not copy already copied files

src/metadata/a48.json

@@ -810,7 +810,7 @@
     "directoryName": "experiences",
     "inFolder": false,
     "metaFile": true,
-    "suffix": "",
+    "suffix": "site",
     "xmlName": "ExperienceBundle"
   },
   {

src/metadata/v47.json

@@ -803,6 +803,7 @@
     "directoryName": "experiences",
     "inFolder": false,
     "metaFile": true,
+    "suffix": "site",
     "xmlName": "ExperienceBundle"
   },
   {

src/metadata/v49.json

@@ -817,6 +817,7 @@
     "directoryName": "experiences",
     "inFolder": false,
     "metaFile": true,
+    "suffix": "site",
     "xmlName": "ExperienceBundle"
   },
   {

src/metadata/v50.json

@@ -817,6 +817,7 @@
     "directoryName": "experiences",
     "inFolder": false,
     "metaFile": true,
+    "suffix": "site",
     "xmlName": "ExperienceBundle"
   },
   {

src/metadata/v51.json

@@ -816,6 +816,7 @@
     "directoryName": "experiences",
     "inFolder": false,
     "metaFile": true,
+    "suffix": "site",
     "xmlName": "ExperienceBundle"
   },
   {

src/metadata/v52.json

@@ -816,6 +816,7 @@
     "directoryName": "experiences",
     "inFolder": false,
     "metaFile": true,
+    "suffix": "site",
     "xmlName": "ExperienceBundle"
   },
   {

src/service/inResourceHandler.js

@@ -4,6 +4,7 @@ const path = require('path')
 const fs = require('fs')
 const mc = require('../utils/metadataConstants')
 
+const STATICRESOURCE_TYPE = 'staticresources'
 const elementSrc = {}
 
 class ResourceHandler extends StandardHandler {
@@ -20,14 +21,16 @@ class ResourceHandler extends StandardHandler {
         'u'
       )
     )
+    this._buildElementMap(srcPath)
 
-    const parsedElementName = path.parse(elementName)
-    if (!Object.prototype.hasOwnProperty.call(elementSrc, srcPath)) {
-      elementSrc[srcPath] = fs.readdirSync(srcPath)
-    }
-
+    const matchingFiles = this._buildMatchingFiles(elementName)
     elementSrc[srcPath]
-      .filter(src => path.parse(src).name === parsedElementName.name)
+      .filter(
+        src =>
+          (this.type === STATICRESOURCE_TYPE &&
+            src.startsWith(path.parse(elementName).name)) ||
+          matchingFiles.includes(src)
+      )
       .forEach(src =>
         this._copyFiles(
           path.normalize(path.join(srcPath, src)),
@@ -70,6 +73,25 @@ class ResourceHandler extends StandardHandler {
         .replace(this.suffixRegex, '')
     )
   }
+
+  _buildMatchingFiles(elementName) {
+    const parsedElementName = path.parse(elementName).name
+    const matchingFiles = [parsedElementName]
+    if (StandardHandler.metadata[this.type].metaFile) {
+      matchingFiles.push(
+        `${parsedElementName}.${StandardHandler.metadata[this.type].suffix}${
+          mc.METAFILE_SUFFIX
+        }`
+      )
+    }
+    return matchingFiles
+  }
+
+  _buildElementMap(srcPath) {
+    if (!Object.prototype.hasOwnProperty.call(elementSrc, srcPath)) {
+      elementSrc[srcPath] = fs.readdirSync(srcPath)
+    }
+  }
 }
 
 module.exports = ResourceHandler

src/service/standardHandler.js

@@ -14,6 +14,8 @@ const FSE_COPYSYNC_OPTION = {
   preserveTimestamps: false,
 }
 
+const copiedFiles = new Set()
+
 class StandardHandler {
   static metadata
 
@@ -98,8 +100,9 @@ class StandardHandler {
   }
 
   _copyFiles(src, dst) {
-    if (fse.pathExistsSync(src)) {
+    if (!copiedFiles.has(src) && fse.pathExistsSync(src)) {
       fse.copySync(src, dst, FSE_COPYSYNC_OPTION)
+      copiedFiles.add(src)
     }
   }