Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue with inResource meta file not copied for corner cases #179

Merged
merged 2 commits into from
Aug 4, 2021

Conversation

scolladon
Copy link
Owner

What does this pull request contains


  • Added for new features.
  • Changed for changes in existing functionality.
  • Deprecated for soon-to-be removed features.
  • Removed for now removed features.
  • Fixed for any bug fixes.
  • Security in case of vulnerabilities.

Explain your changes


Make sure to copy meta file when the inResource have one
Make sure to copy base file for static resource when it is just file (not zip)

Does this close any currently open issues?


closes #176

- [ ] Jest test to check the fix is applied are added.

Any particular element to being able to test locally


Any other comments?


Where has this been tested?


Operating System: Darwin Kernel Version 19.6.0: Tue Jun 22 19:49:55 PDT 2021; root:xnu-6153.141.35~1/RELEASE_X86_64

yarn version: 1.22.11

node version: v14.16.0

git version: 2.32.0

sfdx version: node-v14.16.0

sgd plugin version: 4.8.0

@codeclimate
Copy link

codeclimate bot commented Aug 4, 2021

Code Climate has analyzed commit 4132483 and detected 0 issues on this pull request.

View more on Code Climate.

@scolladon scolladon enabled auto-merge (squash) August 4, 2021 16:31
@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #179 (4132483) into master (ee56c9f) will increase coverage by 0.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #179      +/-   ##
===========================================
+ Coverage   99.77%   100.00%   +0.22%     
===========================================
  Files          19        19              
  Lines         450       459       +9     
===========================================
+ Hits          449       459      +10     
+ Misses          1         0       -1     
Impacted Files Coverage Δ
src/service/inResourceHandler.js 100.00% <100.00%> (+4.00%) ⬆️
src/service/standardHandler.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee56c9f...4132483. Read the comment docs.

@scolladon scolladon disabled auto-merge August 4, 2021 16:45
@scolladon scolladon merged commit 909eba3 into master Aug 4, 2021
@scolladon scolladon deleted the fix/inResource-metaFile-copy branch August 4, 2021 16:45
@alexmodis
Copy link

@scolladon you rox!!! :D 🍾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A forceignored file is still copied into output directory
2 participants