fix: Refactor pipeline secrets to not use ember data #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Refactors the new v2 pipeline secrets route to not use ember data. Also moves the logic for checking if the user is a guest to the
beforeModelmethod since it does not require any model data.Objective
The new v2 UI needs to move off of using ember data due to performance reasons for the events route. The secrets route is currently using ember data to resolve various pieces of data which will not be available as the parent routes will not be using the resolved ember data model for those objects. As such, the data that is needed for this route will now be directly fetched from the API endpoints. The controller was intentionally not updated in this PR as it appears that it currently non-functional anyway.
References
screwdriver-cd/screwdriver#3200
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.