Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Refactor pipeline secrets to not use ember data #1078

Merged
merged 3 commits into from
Jul 2, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 31 additions & 24 deletions app/v2/pipeline/secrets/route.js
Original file line number Diff line number Diff line change
@@ -1,42 +1,49 @@
import Route from '@ember/routing/route';
import { service } from '@ember/service';
import { get } from '@ember/object';

export default class NewPipelineSecretsRoute extends Route {
@service router;

@service session;

@service store;
@service shuttle;

@service router;
async beforeModel() {
// Guests should not access this page
if (this.session.data.authenticated.isGuest) {
this.router.transitionTo('v2.pipeline');
}
}

model() {
async model() {
// Refresh error message
this.controllerFor('v2.pipeline.secrets').set('errorMessage', '');

// Guests should not access this page
if (get(this, 'session.data.authenticated.isGuest')) {
this.router.transitionTo('pipeline');
}

const { pipeline } = this.modelFor('v2.pipeline');
const secrets = pipeline.get('secrets');

this.store.unloadAll('token');

return this.store
.findAll('token', { adapterOptions: { pipelineId: pipeline.get('id') } })
.then(tokens => ({
tokens,
secrets,
pipeline
}))
.catch(error => {
this.controllerFor('pipeline.secrets').set(
const pipelineId = pipeline.id;

const secrets = await this.shuttle
.fetchFromApi('get', `/pipelines/${pipelineId}/secrets`)
.catch(err => {
this.controllerFor('v2.pipeline.secrets').set(
'errorMessage',
err.message
);

return [];
});

const tokens = await this.shuttle
.fetchFromApi('get', `/pipelines/${pipelineId}/tokens`)
.catch(err => {
this.controllerFor('v2.pipeline.secrets').set(
'errorMessage',
error.errors[0].detail
err.message
);

return { secrets, pipeline };
return [];
});

return { pipeline, secrets, tokens };
}
}