Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SERF-2293] Update Go to v1.19.5 #66

Merged
merged 6 commits into from
Feb 6, 2023
Merged

[SERF-2293] Update Go to v1.19.5 #66

merged 6 commits into from
Feb 6, 2023

Conversation

laynax
Copy link
Contributor

@laynax laynax commented Feb 6, 2023 •
edited
Loading

Description

In this PR we update Go version from v1.18.5 to v1.19.5 along with dependent services:

  • Update go version in Dockerfile to golang:1.19.5-alpine3.17 and in go.mod to 1.19 and go.sum.
  • Update golangci-lint to v1.51.1 to adapt new compiler compatibilities and cleared warnings.
  • Fix mage fmt:lint issues (Replace io/ioutils package with io and os packages).
  • Fixed failing test by updating dd-trace-go package to v1.47.0.

Testing considerations

docker-compose build && docker-compose run --rm server mage fmt:lint must run without complain.

Checklist

  • Prefixed the PR title with the JIRA ticket code
  • Performed simple, atomic commits with good commit messages
  • Verified that the commit history is linear and commits are squashed as necessary
  • Thoroughly tested the changes in development and/or staging
  • Updated the README.md as necessary

Related links

@laynax laynax marked this pull request as ready for review February 6, 2023 14:33
@laynax laynax requested a review from a team as a code owner February 6, 2023 14:33
basmscribd
basmscribd previously approved these changes Feb 6, 2023
View reviewed changes
Neurostep
Neurostep approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@Neurostep Neurostep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@laynax laynax merged commit a2be732 into main Feb 6, 2023
@laynax laynax deleted the laynax/SERF-2293/go-119 branch February 6, 2023 16:28
@laynax laynax mentioned this pull request Jul 11, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neurostep Neurostep Neurostep approved these changes

@azclub azclub Awaiting requested review from azclub azclub is a code owner automatically assigned from scribd/service-foundations

@basmscribd basmscribd Awaiting requested review from basmscribd

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laynax @Neurostep @basmscribd