Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SERF-2713] Update Golang version to v1.20 #83

Merged
merged 2 commits into from
Jul 11, 2023
Merged

[SERF-2713] Update Golang version to v1.20 #83

merged 2 commits into from
Jul 11, 2023

Conversation

laynax
Copy link
Contributor

@laynax laynax commented Jul 11, 2023 •
edited
Loading

Description

In this PR we:

  1. Update Golang to v1.20.5
  2. Update the development docker stage to golang:v1.20.5-alpine

Testing considerations

Checklist

  • Prefixed the PR title with the JIRA ticket code
  • Performed simple, atomic commits with [good commit messages][commit messages]
  • Verified that the commit history is linear and commits are squashed as necessary
  • Thoroughly tested the changes in development and/or staging
  • Updated the README.md as necessary

Related links

@laynax laynax requested a review from a team as a code owner July 11, 2023 12:31
@laynax laynax requested review from terranisu and Neurostep and removed request for terranisu July 11, 2023 12:31
Neurostep
Neurostep approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@Neurostep Neurostep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@laynax laynax merged commit 3329d1e into main Jul 11, 2023
4 checks passed
@laynax laynax deleted the laynax/SERF-2713/up branch July 11, 2023 13:09
@Neurostep Neurostep mentioned this pull request Jul 12, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neurostep Neurostep Neurostep approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laynax @Neurostep