Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StaticExtrinsicSigner struct #511

Merged
merged 5 commits into from
Apr 4, 2023
Merged

Add StaticExtrinsicSigner struct #511

merged 5 commits into from
Apr 4, 2023

Conversation

haerdib
Copy link
Contributor

@haerdib haerdib commented Apr 3, 2023

Adds an additional ExtrinsicSigner that does not depend on Runtime input. Instead, the AccountId and Address are hardcoded, as this suffices for most substrate based chains.

closes #461

workaround for #504

@haerdib haerdib self-assigned this Apr 3, 2023
@haerdib haerdib added F7-enhancement Enhances an already existing functionality E1-breaksnothing labels Apr 3, 2023
Copy link
Contributor

@echevrier echevrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I will consider it in #406

Copy link
Contributor

@Niederb Niederb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haerdib haerdib merged commit 116b3e6 into master Apr 4, 2023
@haerdib haerdib deleted the bh/add-static-signer branch April 4, 2023 12:05
@haerdib haerdib changed the title Add static signer Add StaticExtrinsicSigner struct Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E1-breaksnothing F7-enhancement Enhances an already existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce a no-wasm compatible ExtrinsicSigner
3 participants