Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pylint is invoked incorrectly if .pylintrc is not present #62

Closed
volviq opened this issue Mar 1, 2018 · 2 comments
Closed

pylint is invoked incorrectly if .pylintrc is not present #62

volviq opened this issue Mar 1, 2018 · 2 comments

Comments

@volviq
Copy link
Contributor

volviq commented Mar 1, 2018 •
edited
Loading

When committing, the pylint result is always shown as "0" although the python files are getting a rating of "10.0" when pylint is run manually.
If no .pylintrc is present, the script should not pass a parameter for .pylintrc, so that pylint runs with defaults.
@volviq
Copy link
Contributor Author

volviq commented Mar 1, 2018 •
edited
Loading

Alternatively, it would be good, if a global .pylintrc can be used.
The use case for this is having a hooksPath set in .gitconfig which is available since git v2.90. There will always be project which do not yet have a .pylintrc inside the repository.

At least the error messages of pylint should be printed with some meaning. see #58

@volviq volviq changed the title pylint result is interpreted 0 every time pylint is invoked incorrectly if .pylintrc is not present Mar 9, 2018
volviq added a commit to volviq/git-pylint-commit-hook that referenced this issue Mar 9, 2018
@volviq
issue sebdah#62 skip pylintrc in case file doesn't exist
e6f6fdb 
Do not pass "--rcfile" to pylint, in case .pylintrc is not present.
volviq added a commit to volviq/git-pylint-commit-hook that referenced this issue Mar 10, 2018
@volviq
issue sebdah#62 skip pylintrc in case file doesn't exist
e3de7bd 
Do not pass "--rcfile" to pylint, in case .pylintrc is not present.
@volviq volviq mentioned this issue Mar 10, 2018
Merged
@sebdah sebdah mentioned this issue Mar 12, 2018
Merged
@sebdah
Copy link
Owner

sebdah commented Mar 12, 2018

Fixed with #63 and released in 2.4.0

@sebdah sebdah closed this as completed Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sebdah @volviq