[sebdah-62] Skip pylintrc parameter if file not present #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volviq
force-pushed
the
sebdah-62-missing-pylintrc
branch
2 times, most recently
from
a5db73e
to
e6f6fdb
Compare
sebdah
requested changes
Mar 9, 2018
| @@ -269,9 +271,11 @@ def check_repo( | |||
| if pylint_params: | |||
| command += pylint_params.split() | |||
| if '--rcfile' not in pylint_params: | |||
| command.append('--rcfile={}'.format(pylintrc)) | |||
| if pylintrc is not None: | |||
There was a problem hiding this comment.
Please change this to if not pylintrc to be more Pythonic.
There was a problem hiding this comment.
I assume you mean "change this to if pylintrc"?
| else: | ||
| command.append('--rcfile={}'.format(pylintrc)) | ||
| if pylintrc is not None: |
There was a problem hiding this comment.
Please change this to if not pylintrc to be more Pythonic.
There was a problem hiding this comment.
I assume you mean "change this to if pylintrc"?
Do not pass "--rcfile" to pylint, in case .pylintrc is not present.
volviq
force-pushed
the
sebdah-62-missing-pylintrc
branch
from
e6f6fdb
to
e3de7bd
Compare
|
@sebdah nitpicks adressed. General question: what's the planned release cycle, and when (rough estimate) would you expect then next one to go into pip? I don't know how the process works, so maybe you can't even answer that question. |
|
Thanks! There is no release cycle per se. I'm merge this and ship it either
today or tomorrow. I'm traveling today, so it depends a little on if I find
a good window.
…On Sat, Mar 10, 2018, 7:13 PM volviq ***@***.***> wrote:
@sebdah <https://github.com/sebdah> nitpicks adressed.
General question: what's the planned release cycle, and when (rough
estimate) would you expect then next one to go into pip? I don't know how
the process works, so maybe you can't even answer that question.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#63 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA0QLGaxBLyKNWdENy6nV7ErVEcxfkjpks5tdBfkgaJpZM4SkUZE>
.
|
sebdah
approved these changes
Mar 12, 2018
|
Yes please close #62
#61 is far from being done.
On 12 Mar 2018 04:43, "Sebastian Dahlgren" <[email protected]> wrote:
@volviq <https://github.com/volviq> I have released version 2.4.0 to PyPI
now! Thanks for this PR. Should we close #62
<#62> now and keep
#61 <#61> open still?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#63 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AErY9AHBzd2-uDYZNykodXBfTPhVkPioks5tdf0FgaJpZM4SkUZE>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case there is no .pylintrc file, skip the --rcfile parameter in
pylintrc invocation.