Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add agmFitBounds to AgmPolylinePoint #1693

Closed
johnheroy opened this issue Jul 21, 2019 · 5 comments · Fixed by #1720
Closed

Add agmFitBounds to AgmPolylinePoint #1693

johnheroy opened this issue Jul 21, 2019 · 5 comments · Fixed by #1720

Comments

@johnheroy
Copy link

Issue description
It looks like the agmFitBounds directive only works for AdmMarker but not AdmPolylinePoint, this would be helpful for map components which just render polylines.

@terencehonles
Copy link
Contributor

@doom777 once we get #1704 and #1648 merged in I'll hopefully have some time to look at this. I noticed this was missing and worked around it in our application, but this is something I may be able to contribute in the future. (I'd like to get the others PRs merged in first though, and I'll update #1648 when we get #1704 in)

@loremaps
Copy link
Contributor

loremaps commented Sep 5, 2019

Would agm-circle be consider as well?

@ghost
Copy link

ghost commented Sep 5, 2019

@loremaps you can write it up, and make a PR

@loremaps
Copy link
Contributor

loremaps commented Sep 8, 2019

I gave it a shot for agm-polyline-point...but for agm-circle I am not sure if the whole circle should fit or the just the center 🤔 What do you guys think?

@ghost
Copy link

ghost commented Sep 8, 2019

Whole circle

@ghost ghost closed this as completed in #1720 Sep 16, 2019
ghost pushed a commit that referenced this issue Sep 16, 2019
Allow agm polyline point to allow autofitting around polylines.

Closes #1693
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants