feat(FitBounds): add fitBounds to agm-polyline-point #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
suggested changes
Sep 8, 2019
| getFitBoundsDetails$(): Observable<FitBoundsDetails> { | ||
| return this.positionChanged.pipe( | ||
| startWith({lat: this.latitude, lng: this.longitude}), | ||
| map(x => ({latLng: x})) |
There was a problem hiding this comment.
rename x to position or some other meaningful name
There was a problem hiding this comment.
Thanks, used position
Codecov Report
@@ Coverage Diff @@
## master #1720 +/- ##
==========================================
+ Coverage 47.9% 48.01% +0.11%
==========================================
Files 41 41
Lines 1812 1818 +6
Branches 167 167
==========================================
+ Hits 868 873 +5
- Misses 940 941 +1
Partials 4 4
Continue to review full report at Codecov.
|
ghost
approved these changes
Sep 9, 2019
|
@doom777 Thanks for the review. I hope I have address all requested changes. |
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1693