Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implements mapDblClick event #880

Conversation

dangerdespain
Copy link
Contributor

The mouse event emitter was missing for mapDblClick - this should solve the issue but is untested. Should resolve #879

The mouse event emitter was missing for mapDblClick - this should solve the issue but is untested
@GitCop
Copy link

GitCop commented Feb 1, 2017

There were the following issues with your Pull Request

  • Commit: dbda2da
  • Commits must be in the following format: %{type}(%{scope}): %{description}

Contribution guidelines are available at https://github.com/SebastianM/angular2-google-maps/blob/master/CONTRIBUTING.md


This message was auto-generated by https://gitcop.com

@dangerdespain
Copy link
Contributor Author

Sorry for the poor contribution format - I'm literally making this update in a client meeting haha.. Let me know if this needs to be cleaned up. Thanks!

@sebholstein
Copy link
Owner

Thx!

@sebholstein sebholstein closed this Feb 9, 2017
sebholstein pushed a commit that referenced this pull request Feb 9, 2017
The mouse event emitter was missing for mapDblClick

Fixes #879
Closes #880
@paulsson
Copy link

paulsson commented Apr 5, 2017

@SebastianM
I just installed from npm which still does not seem to contain this fix.
I got version 0.17.0:

"angular2-google-maps": "^0.17.0", 

I looked at the code in node_modules and don't see the fix there.

This file:
src/core/directives/map.ts
doesn't exist under the 0.17.0 tag:
https://github.com/SebastianM/angular2-google-maps/tree/0.17.0/src/core/directives

Will you push out a new version soon that includes this fix? Or do I need to npm install from master for now?

Thanks!

@sebholstein
Copy link
Owner

@paulsson the new version 1.0.0-beta.0 contains this. Please read the CHANGELOG.md file in this repo

@paulsson
Copy link

Thank you @SebastianM !

franknwankwo pushed a commit to caravancoop/angular2-google-maps that referenced this pull request Jun 7, 2017
The mouse event emitter was missing for mapDblClick

Fixes sebholstein#879
Closes sebholstein#880
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mapDblClick event is not firing
4 participants