Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe-App Group Capstone #42

Merged
merged 180 commits into from
Sep 8, 2023
Merged

Recipe-App Group Capstone #42

merged 180 commits into from
Sep 8, 2023

Conversation

Mar12358
Copy link
Collaborator

@Mar12358 Mar12358 commented Sep 8, 2023

Added Features:

Participans: @SergioPeralta22 @lincoln1883 @Mar12358

  • Follow the layout of the wireframes provided and add personalization. For more details visit this Link
  • Login page and registration page:
    • Built with Devise.
  • Food list
    • Displays a list of food added by the logged-in user as in the wireframe.
    • Leads to a form that allows users to add new food.
  • Recipes list:
    • Displays a list of recipes created by the logged-in user as in the wireframe.
    • Leads to recipe details.
    • If the user is the owner of the recipe, it allows the user to delete it.
  • Public recipe list:
    • Displays a list of all public recipes.
    • Leads to recipe details.
  • Recipe details:
    • Displays a button that allows for a recipe to be made public or private.
    • If the recipe is public or the user is the owner of the recipe, it displays the recipe details as in the wireframe.
    • If the user is the owner of the recipe, it leads to the form that allows the user to add new food.
  • Inventories list:
    • Displays a list of inventories created by the logged-in user as in the wireframe.
    • Leads to inventory details.
    • If the user is the owner of the inventory, it allows to delete it.
  • Inventory details:
    • Displays the inventory details as in the wireframe.
    • Leads to a form that allows users to add new food.
  • Recipe details:
    • Has a modal to choose an inventory to create a shopping list with, as in the wireframe.
  • Inventory shopping list:
    • Shows the list of food that is missing by comparing the food in the recipe with the food in the inventory.
    • Counts the total food items and total price of the missing food.
  • No N+1 queries happening.
  • Navigation menu that allows users to open all of the pages you created.
  • Unit and integration tests
    image

Copy link

@Whoistolu Whoistolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Mar12358 , @SergioPeralta22 and @lincoln1883

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:

STATUS: APPROVED 🟢

Congratulations! 🎉

  • Check the inline comments under the review for sections to improve.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @Whoistolu in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@@ -0,0 +1,14 @@
class User < ApplicationRecord
# Include default devise modules. Others available are:
# :confirmable, :lockable, :timeoutable, :trackable and :omniauthable

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • [OPTIONAL] Great job implementing devise for sign-up and sign-in, however, it will be nice if you enable :confirmable so that a user will be able to confirm their email after sign-up and before finally signing in. This helps to keep the account more secure.

@lincoln1883 lincoln1883 merged commit 329f319 into main Sep 8, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants