-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recipe-App Group Capstone #42
Conversation
Feature/models
…iews-setup Feature controllers and views setup
Feature/test/views
Feature unit test
Feature/documentation
Fix n+1 querie issues
Improve Style and Fix Links
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Mar12358 , @SergioPeralta22 and @lincoln1883
Your project is complete! There is nothing else to say other than... it's time to merge it
STATUS: APPROVED 🟢
Congratulations! 🎉
- Check the inline comments under the review for sections to improve.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @Whoistolu in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
@@ -0,0 +1,14 @@ | |||
class User < ApplicationRecord | |||
# Include default devise modules. Others available are: | |||
# :confirmable, :lockable, :timeoutable, :trackable and :omniauthable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [OPTIONAL] Great job implementing devise for sign-up and sign-in, however, it will be nice if you enable
:confirmable
so that a user will be able to confirm their email after sign-up and before finally signing in. This helps to keep the account more secure.
Added Features:
Participans: @SergioPeralta22 @lincoln1883 @Mar12358