Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5.0.0 Release #210

Merged
merged 47 commits into from
Jun 25, 2021
Merged

5.0.0 Release #210

merged 47 commits into from
Jun 25, 2021

Conversation

nblumhardt
Copy link
Member

@nblumhardt nblumhardt commented Mar 16, 2021 •
edited
Loading

thiagosgarcia and others added 30 commits April 30, 2019 16:31
@thiagosgarcia
Merge pull request #1 from serilog/dev
ab568af 
Update Fork
@thiagosgarcia
File retention policy by date - Add configuration to discard files ol…
1596f80 
…der than X time

Fixed constructors for compatibility; Unified where clause to retain files
Adjust error messages
New test cases
@thiagosgarcia
Refactoring file filter; fixing docs
b213a7a
@EamonHetherton
Merge pull request #1 from serilog/dev
f3abfb8 
Merge
@maciejw
update github sourcelink support package to latest version
2d3cee7
@nblumhardt
Merge pull request #123 from maciejw/update-sourcelink
a6f9324 
update github sourcelink support package to latest version
@nblumhardt
Major version bump; accepting breaking changes into dev
1093c3b
@nblumhardt
Remove explicit private modifier; name tweak; reorganize some conditi…
1b863ff 
…onals
@nblumhardt
Merge branch 'dev' into dev
00e3e94
@nblumhardt
Fix test; update to use the 2019 build image
c2375eb
@nblumhardt
Merge branch 'thiagosgarcia-dev' into dev
a015038
@nblumhardt
.NET Core App 3.0 target; misc clean-up
73ac5ff
@nblumhardt
Cut back frameworks targeted by tests to keep build manageable
849ad79
@nblumhardt
Merge pull request #130 from nblumhardt/netcoreapp30
74b09e8 
.NET Core App 3.0 target; misc clean-up
@EamonHetherton
Added way to chain FileLifeCycleHooks together
6df7cae
@EamonHetherton
stop using params when current implementation only ever has two values
1af5096
@EamonHetherton
Merge remote-tracking branch 'upstream/master' into dev
958bf02
@EamonHetherton
Merge branch 'dev' of https://github.com/EamonHetherton/serilog-sinks…
76af134 
…-file into dev
@EamonHetherton
refactor "ChainTo" to instance method "Then"
cad86bd
@nblumhardt
Merge pull request #141 from EamonHetherton/dev
7106445 
Add extension method to chain FileLifecycleHooks together
@cocowalla
docs: file lifecycle hooks
5358051
@nblumhardt
Merge pull request #145 from serilog/docs/life-cycle-hooks
865b9f2 
docs: file lifecycle hooks
@cocowalla
fix: #146, file size limit
2be5531
@cocowalla
Merge pull request #147 from serilog/fix/file-size-limit
e712ec2 
fix: #146, file size limit
@nblumhardt
Update NuGet.org publishing key
455c32c
@rafaelsc
Merge pull request #1 from serilog/dev
7938c90 
Merge
@rafaelsc
Improve XML Docs
e44e591
@nblumhardt
Merge pull request #167 from rafaelsc/feature/improveDocumentation
512587f 
Improves XML documentation
@augustoproiete
Update project to use SPDX LicenseExpression (resolve warning NU5125:…
f155fab 
… The 'licenseUrl' element will be deprecated)
@augustoproiete
Add embedded icon to NuGet package (resolve warning NU5048: The 'Pack…
d8c6571 
…ageIconUrl'/'iconUrl' element is deprecated)
nblumhardt and others added 5 commits November 9, 2020 19:01
@nblumhardt
Merge pull request #190 from augustoproiete-forks/update-metadata-for…
2f6f1b6 
…-nuget

Update metadata for NuGet
@augustoproiete
Add ability to capture path of log file opened, via FileLifecycleHooks
4c8c3d4
@nblumhardt
Merge pull request #189 from augustoproiete-forks/capture-log-file-pa…
7cf84eb 
…th-in-hooks

Add ability to capture path of log file opened, via FileLifecycleHooks
@pvandervelde
Including the RollingFileSink initialization in the try..catch so tha…
bd4d7dd 
…t any errors in the creation are included in the self log
@nblumhardt
Merge pull request #196 from pvandervelde/fix-192
771be4f 
Including the RollingFileSink initialization in the try..catch; fixes #192
@nblumhardt nblumhardt mentioned this pull request Mar 16, 2021
Closed
@tkrafael
Copy link

Can you please check for this PR: #204
I've made the merge and ran all tests successfully.

bdovaz and others added 9 commits June 11, 2021 18:20
@bdovaz
Remove unnecessary dependencies
91cd684
@nblumhardt
Merge pull request #222 from bdovaz/remove-netstandard20-dependencies
6d437b2 
Remove unnecessary dependencies on netstandard 2.0 target
@nblumhardt
Publishing key update
d599eb6
@nblumhardt
Unpin the assembly version; fixes #135
a1ba60e
@nblumhardt
Remove matching test
6f43751
@nblumhardt
Merge pull request #227 from nblumhardt/unpin-assembly-version
be730d4 
Unpin the assembly version
@rafaelsc @nblumhardt
Add support C# 8 nullable reference types (#166)
08ff445 
* Initial Nullable Support

* Update Nullable Reference Support

* Update appveyor config

* Update Test Project

* Update Test Project

* Code Format

* Code Refactor

* Remove unnecessary references

* Simplifying Constants

* Add More TargetFrameworks for
Update References
Cleanup References

* Remove netcoreapp3.0 to use netstandard2.0 insted

* Unpin the assembly version; fixes #135

* Remove matching test

Co-authored-by: Nicholas Blumhardt <[email protected]>
@nblumhardt
Add net5.0 target; use (source-only) Nullable package instead of bund…
edd4ba9 
…ling down-level attributes (#228)
@augustoproiete @nblumhardt
Allow FileLifecycleHooks to change the length of the stream. Resolves #…
a2fa447 
…186
@nblumhardt nblumhardt mentioned this pull request Jun 22, 2021
Closed
@nblumhardt nblumhardt marked this pull request as ready for review June 22, 2021 03:23
@nblumhardt
Copy link
Member Author

Okay, folks, 5.0.0-dev-00935 should be the last preview package for this release!

It will need some smoke testing - if you have an app or package that depends on this sink and can try it out, 👍 or 👎 appreciated 😁 .

@nblumhardt nblumhardt changed the base branch from master to main June 22, 2021 03:26
@Numpsy
Copy link
Member

Numpsy commented Jun 22, 2021 •
edited
Loading

Is the Serilog.Sinks.File nuget package supposed to reference the Nullable nuget package, or should it just be a dev dependency?

(The Nullable docs at https://github.com/manuelroemer/Nullable#quickstart suggest that the PackageReference in the consuming project should have PrivateAssets="all" set to avoid that happening but the File sink project here doesn't do that (it does for the Sourcelink reference which is a similar build-time dependency))

Same Q. for the main Serilog package fwiw

@nblumhardt
Copy link
Member Author

@Numpsy nice spotting, thanks!

@nblumhardt nblumhardt merged commit 7eb21bd into main Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.