Add google analytics / migrate to npm #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
place in keys/ga_tag
`yarn build` has been giving a lot of grief about proper types for the pino logger
sgfost
force-pushed
the
add_google_analytics
branch
2 times, most recently
from
3e12313
to
c1c4bf9
Compare
migration steps for future ref: - replace yarn install with npm install - (npm ci == yarn install --frozen-lockfile) - replace yarn <script> with npm run <script> - use `--` when passing args to scripts called with npm run - replace yarn.lock references with package-lock.json - remove node_modules and yarn.lock, run npm i - optionally prevent using yarn with package.json "engines" trick resolves virtualcommons#926
sgfost
force-pushed
the
add_google_analytics
branch
from
c1c4bf9
to
da36603
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing ci run