Compute unix_ts_start via created-ts and now-ts. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far we computed stream start time by subtracting the largest number of elapsed microseconds from the stream end time. This worked well for successful streams, but not so well for errors where the error might have occurred long after recording the microsecond timestamp of a successful substep. With this change we subtract the difference between created-ts and now-ts from the stream end time for a more accurate stream start time. Only if these timestamps are unknown we fall back to setting start and end time to the same value. This issue first came up in: https://gitlab.torproject.org/tpo/metrics/onionperf/-/issues/30362
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far we computed stream start time by subtracting the largest number
of elapsed microseconds from the stream end time. This worked well for
successful streams, but not so well for errors where the error might
have occurred long after recording the microsecond timestamp of a
successful substep.
With this change we subtract the difference between created-ts and
now-ts from the stream end time for a more accurate stream start time.
Only if these timestamps are unknown we fall back to setting start and
end time to the same value.
This issue first came up in:
https://gitlab.torproject.org/tpo/metrics/onionperf/-/issues/30362