Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute unix_ts_start via created-ts and now-ts. #11

Merged
merged 1 commit into from
Jul 21, 2020

Commits on Jul 21, 2020

  1. Compute unix_ts_start via created-ts and now-ts.

    So far we computed stream start time by subtracting the largest number
    of elapsed microseconds from the stream end time. This worked well for
    successful streams, but not so well for errors where the error might
    have occurred long after recording the microsecond timestamp of a
    successful substep.
    
    With this change we subtract the difference between created-ts and
    now-ts from the stream end time for a more accurate stream start time.
    Only if these timestamps are unknown we fall back to setting start and
    end time to the same value.
    
    This issue first came up in:
    
    https://gitlab.torproject.org/tpo/metrics/onionperf/-/issues/30362
    kloesing committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    7350f82 View commit details
    Browse the repository at this point in the history