Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low latency DASH support #979

Conversation

CaitlinOCallaghan
Copy link
Contributor

@CaitlinOCallaghan CaitlinOCallaghan commented Aug 17, 2021

LL-DASH Support

These changes add support for LL-DASH streaming.
While writing this feature, I have been checking in with @joeyparrish to get feedback along the way. See the original PRs here.

NOTE: LL-HLS support is still in progress, but it's coming. :)

Testing

./chunking_unittest --gtest_filter="ChunkingHandlerTest.LowLatencyDash"

./media_event_unittest --gtest_filter="MpdNotifyMuxerListenerTest.LowLatencyDash"

./mpd_unittest --gtest_filter="PeriodTest.LowLatencyDashMpdGetXml"
./mpd_unittest --gtest_filter="SimpleMpdNotifierTest.NotifyAvailabilityTimeOffset"
./mpd_unittest --gtest_filter="SimpleMpdNotifierTest.NotifySegmentDuration"
./mpd_unittest --gtest_filter="LowLatencySegmentTest.LowLatencySegmentTemplate"

Note, packager_test must be run from the main project directory
./out/Release/packager_test --gtest_filter="PackagerTest.LowLatencyDashEnabledAndUtcTimingNotSet"
./out/Release/packager_test --gtest_filter="PackagerTest.LowLatencyDashEnabledAndUtcTimingNotSet"

Documentation

image
image

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Aug 17, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@CaitlinOCallaghan
Copy link
Contributor Author

CaitlinOCallaghan commented Aug 18, 2021

Hi,

I need help with the CLA agreement. I have been able to send PRs to Shaka Streamer, so I know my email [email protected] is valid with my company's CLA.

When I run git shortlog -e -s -n | grep "Caitlin O'Callaghan" to check my commits and associated emails I see:
image

Do you reckon the "@users.noreply.github.com" handle from my merges is causing an issue? I peeked in Packager's commit history and saw that other people committed/merged with the "@users.noreply.github.com" handle, and I didn't see issues with their PRs, so I'm not sure that is the problem.

@kevleyski
Copy link

Thanks Caitlin

@kqyang
Copy link
Contributor

kqyang commented Aug 18, 2021

@CaitlinOCallaghan Thanks for the PR!

I checked the CLA, here is what I got:

PullRequest Sender

GitHub Login Email State
CaitlinOCallaghan [email protected] ok

Commit Author(s)

GitHub Login Email State
caitlinocallaghan [email protected] ok
caitlinocallaghan [email protected] need_author_cla

So yes, the problem is with [email protected] email address.

There are two options:

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Aug 23, 2021

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@joeyparrish
Copy link
Member

I need to figure out what is wrong with the PR workflow. I'll let you know when I've figured that out. You may need to rebase/merge at that point to pick up the fix.

I'll also try to give this a thorough review soon. Definitely this week.

@joeyparrish
Copy link
Member

You should be able to fix the CI issues by rebasing/merging with the master branch now. Sorry for the inconvenience!

Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kevleyski
Copy link

kevleyski commented Aug 25, 2021 via email

@CaitlinOCallaghan
Copy link
Contributor Author

@joeyparrish No worries! Thank you for the fix and approval!

@joeyparrish joeyparrish merged commit cd018a7 into shaka-project:master Aug 25, 2021
@joeyparrish
Copy link
Member

Woohoo! Thanks, Caitlin!

@kevleyski
Copy link

Thanks again @CaitlinOCallaghan great work
Much appreciated

@@ -126,6 +126,8 @@ class Segmenter {
virtual Status DoFinalize() = 0;
virtual Status DoFinalizeSegment() = 0;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(minor formatting)

sr1990 pushed a commit to sr1990/shaka-packager that referenced this pull request Feb 18, 2023
# LL-DASH Support
These changes add support for LL-DASH streaming. 

**NOTE:** LL-HLS support is still in progress, but it's coming. :) 

## Testing
`./chunking_unittest --gtest_filter="ChunkingHandlerTest.LowLatencyDash"`

`./media_event_unittest --gtest_filter="MpdNotifyMuxerListenerTest.LowLatencyDash"`

`./mpd_unittest --gtest_filter="PeriodTest.LowLatencyDashMpdGetXml"`
`./mpd_unittest --gtest_filter="SimpleMpdNotifierTest.NotifyAvailabilityTimeOffset"`
`./mpd_unittest --gtest_filter="SimpleMpdNotifierTest.NotifySegmentDuration"`
`./mpd_unittest --gtest_filter="LowLatencySegmentTest.LowLatencySegmentTemplate"`

Note, packager_test must be run from the main project directory
`./out/Release/packager_test --gtest_filter="PackagerTest.LowLatencyDashEnabledAndUtcTimingNotSet"`
`./out/Release/packager_test --gtest_filter="PackagerTest.LowLatencyDashEnabledAndUtcTimingNotSet"`
sr1990 pushed a commit to sr1990/shaka-packager that referenced this pull request Feb 18, 2023
# LL-DASH Support
These changes add support for LL-DASH streaming. 

**NOTE:** LL-HLS support is still in progress, but it's coming. :) 

## Testing
`./chunking_unittest --gtest_filter="ChunkingHandlerTest.LowLatencyDash"`

`./media_event_unittest --gtest_filter="MpdNotifyMuxerListenerTest.LowLatencyDash"`

`./mpd_unittest --gtest_filter="PeriodTest.LowLatencyDashMpdGetXml"`
`./mpd_unittest --gtest_filter="SimpleMpdNotifierTest.NotifyAvailabilityTimeOffset"`
`./mpd_unittest --gtest_filter="SimpleMpdNotifierTest.NotifySegmentDuration"`
`./mpd_unittest --gtest_filter="LowLatencySegmentTest.LowLatencySegmentTemplate"`

Note, packager_test must be run from the main project directory
`./out/Release/packager_test --gtest_filter="PackagerTest.LowLatencyDashEnabledAndUtcTimingNotSet"`
`./out/Release/packager_test --gtest_filter="PackagerTest.LowLatencyDashEnabledAndUtcTimingNotSet"`
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants