Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Low latency dash support staging #88

Merged
merged 17 commits into from
Aug 25, 2021
Merged

Low latency dash support staging #88

merged 17 commits into from
Aug 25, 2021

Conversation

CaitlinOCallaghan
Copy link
Contributor

CaitlinOCallaghan and others added 16 commits August 13, 2021 00:02
@CaitlinOCallaghan
PipelineConfig fields for utc_timings and is_low_latency_dash to trig…
bf0d4b8 
…ger LL-DASH streaming within Packager
@CaitlinOCallaghan
WIP restrictions on LL-DASH input
a1d95b6
@CaitlinOCallaghan
Logic and Config input cleanup
a6667ae
@CaitlinOCallaghan
Unit test for UTCTiming and LL-DASH restriction
7a383ea
@CaitlinOCallaghan
Unit test for LL-DASH and DASH manifest validation
75cdccb
@CaitlinOCallaghan
WIP: Unit test to verify LL-DASH playout
b6b2e75
@CaitlinOCallaghan
Remove unnecessary newline
7e69ed4
@CaitlinOCallaghan
Cleanup
40e6c55
@CaitlinOCallaghan
More cleanup
7723b85
@CaitlinOCallaghan
Fix to pass LL-DASH testcase: update dashStreamsReady() fn to account…
19b9b8c 
… for LL-DASH MPD
@CaitlinOCallaghan
Style and typo fix
8b17058
@CaitlinOCallaghan
Naming change for LL-DASH control hook
76505e4
@CaitlinOCallaghan
Write TODOs
a8e9661
@CaitlinOCallaghan
Change LL-DASH flag in PackagerNode to match new flag name in Shaka P…
06ef351 
…ackager
@CaitlinOCallaghan
Sample pipeline config file for LL-DASH mode
fd1724d
@CaitlinOCallaghan
Merge pull request #3 from CaitlinOCallaghan/low-latency-dash-support
bdb76f3 
Low latency dash support
joeyparrish
joeyparrish approved these changes Aug 23, 2021
View reviewed changes
Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise, though.

config_files/pipeline_low_latency_dash_config.yaml Outdated Show resolved Hide resolved
@CaitlinOCallaghan CaitlinOCallaghan marked this pull request as ready for review August 25, 2021 03:07
@joeyparrish joeyparrish merged commit 4fc6d19 into shaka-project:master Aug 25, 2021
shaka-bot pushed a commit that referenced this pull request Aug 26, 2021
@joeyparrish
Temporarily revert "Low latency dash support staging (#88)"
2a4d307 
This reverts commit 4fc6d19.

The corresponding Packager release is not ready yet, so this feature
in Streamer is being temporarily reverted.  It will be restored after
the v0.4.0 release, with the intent of shipping it in v0.5.0 instead.

Change-Id: I3d660ff71fee84450576a4bd5672379dd9903fe7
shaka-bot pushed a commit that referenced this pull request Aug 26, 2021
@joeyparrish
Restore "Low latency dash support staging (#88)"
0cf0678 
This reverts commit 2a4d307,
restoring LL-DASH support in anticipation of v0.5.0.

Change-Id: I688ea46180755d3f1076ed3b386be57d29583cf7
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CaitlinOCallaghan @joeyparrish