XML text subtitles (bg)color not applied to doubly nested cues #3521
Assignees
Labels
priority: P2
Smaller impact or easy workaround
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
Milestone
Comments
11 tasks
joeyparrish
added
type: bug
11 tasks
|
Note: the same issue occurs with font-size |
|
Hi @TheModMaker I wonder if there is a small tweak needed to deal with the extra piece of background fill that appears to the right of the first of a two line cue. |
joeyparrish
pushed a commit
that referenced
this issue
Jan 5, 2022
First, the positioning of cues was incorrect. We need to explicitly set all the position attributes when we position elements with the "absolute" position. Second, if we position a text <span> manually, the background will fill the whole region. So to keep the background wrapping the text, we need to add another <span> for the text. Third, the background and font color should not be set on every <span> element since it won't allow parent cues to set the inherited value. So this moves the defaults to the top-level text element and allows parent cue elements to override this. It also would make app CSS easier to override. Because background color isn't inherited through CSS, the default is set in JavaScript instead. Fixes #3521 Fixes #3600 Closes #3713 Backported to v3.1.x Change-Id: I45fc88dcac4a0a062e1474087f24c80d98eef619
joeyparrish
pushed a commit
that referenced
this issue
Jan 5, 2022
First, the positioning of cues was incorrect. We need to explicitly set all the position attributes when we position elements with the "absolute" position. Second, if we position a text <span> manually, the background will fill the whole region. So to keep the background wrapping the text, we need to add another <span> for the text. Third, the background and font color should not be set on every <span> element since it won't allow parent cues to set the inherited value. So this moves the defaults to the top-level text element and allows parent cue elements to override this. It also would make app CSS easier to override. Because background color isn't inherited through CSS, the default is set in JavaScript instead. Fixes #3521 Fixes #3600 Closes #3713 Backported to v3.2.x Change-Id: I45fc88dcac4a0a062e1474087f24c80d98eef619
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
v3.1.1
Can you reproduce the issue with our latest release version?
Yes
https://shaka-player-demo.appspot.com/demo/#audiolang=en-US;textlang=en-US;uilang=en-US;asset=https://livesim.dashif.org/dash/vod/testpic_2s/xml_subs.mpd;panel=CUSTOM%20CONTENT;build=uncompiled
Can you reproduce the issue with the latest code from
master?Yes
Are you using the demo app or your own custom app?
Shaka Demo but also own custom app
If custom app, can you reproduce the issue using our demo app?
yes
What browser and OS are you using?
Windows 10 & Mac Big Sur
Chrome 91
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
N/A
What are the manifest and license server URIs?
[Clear] https://livesim.dashif.org/dash/vod/testpic_2s/xml_subs.mpd
What configuration are you using? What is the output of
player.getConfiguration()?Default configuration
What did you do?
Play this stream.
Enable English Captions
View the subtitles rendered at 0h0m1s to 0h0m2s
What did you expect to happen?
Should see Blue background Yellow text
What actually happened?
White text on black
Please assign this to me as I have written a failing UT and have a proposed fix for it.
It is a side effect of changes to XML parsing changes in recent versions.
The text was updated successfully, but these errors were encountered: