3521 fix for double nested color subtitles #3522
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyparrish
reviewed
Jul 13, 2021
| style.backgroundColor = cue.backgroundColor; | ||
| } | ||
| if (isLeaf && parentCue && cue.backgroundColor == '') { | ||
| style.backgroundColor = parentCue.backgroundColor; |
There was a problem hiding this comment.
This really seems like something that should be solved with style inheritance instead. Do you have any idea why the element doesn't already inherit the parent's background and color styles?
There was a problem hiding this comment.
The problem is that the styles defined here (https://github.com/google/shaka-player/blob/master/ui/less/containers.less#L229-L235) overwrite those of the parent element (background-color and color)
|
Closing this as a simpler fix can be made in CSS after observations from community. |
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TTML Parser can produce multiple depth nested cues where colors set at one level need to be applied down further.
Fixes #3521 by ensuring the
parentCueis considered for bg/color in the Text Displayer passing null at the top layer and the parent down whenever processing nesting of cues.Screenshots (optional)
Type of change
not work as expected)
Checklist:
./build/all.pyand the build passes./build/test.pyand all tests pass