Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tizen unable to play clear when configured for DRM due to #2620 workaround #3589

Closed
david-hm-morgan opened this issue Aug 20, 2021 · 5 comments · Fixed by #3625
Closed

Tizen unable to play clear when configured for DRM due to #2620 workaround #3589

david-hm-morgan opened this issue Aug 20, 2021 · 5 comments · Fixed by #3625
Assignees
Labels
flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@david-hm-morgan
Copy link
Contributor

david-hm-morgan commented Aug 20, 2021

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
v3.2.0
(v3.0.11 & v3.1.1 also)

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from master?
Yes

Are you using the demo app or your own custom app?
Own custom demo app at https://otvplayer.nagra.com/demo/content/shakaPlayer/issue2620TizenSideEffect/

If custom app, can you reproduce the issue using our demo app?
No because need to customise DRM config

What browser and OS are you using?
Tizen Smart TV

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
Tizen 3/5/5.5/6

What are the manifest and license server URIs?

https://otvplayer.nagra.com/demo/content/bbc/bbc_segmented_snaking_subtitle/dash/ondemand/elephants_dream/1/client_manifest-snake.mpd

What configuration are you using? What is the output of player.getConfiguration()?

Click to expand
abr:
bandwidthDowngradeTarget: 0.95
bandwidthUpgradeTarget: 0.85
defaultBandwidthEstimate: 1000000
enabled: true
restrictions:
maxBandwidth: Infinity
maxFrameRate: Infinity
maxHeight: Infinity
maxPixels: Infinity
maxWidth: Infinity
minBandwidth: 0
minFrameRate: 0
minHeight: 0
minPixels: 0
minWidth: 0
switchInterval: 8
useNetworkInformation: true
abrFactory: ƒ ()
drm:
advanced: {}
clearKeys: {}
delayLicenseRequestUntilPlayed: false
initDataTransform: ƒ (a,b,c)
logLicenseExchange: false
preferredKeySystems: []
retryParameters:
backoffFactor: 2
baseDelay: 1000
connectionTimeout: 10000
fuzzFactor: 0.5
maxAttempts: 2
stallTimeout: 5000
timeout: 30000
servers: {com.microsoft.playready: "https://uex3xj0i.anycast.nagra.com/UEX3XJ0I/prls/contentlicenseservice/v1/licenses", com.widevine.alpha: "https://uex3xj0i.anycast.nagra.com/UEX3XJ0I/wvls/contentlicenseservice/v1/licenses"}
updateExpirationTime: 1
manifest:
availabilityWindowOverride: NaN
dash:
autoCorrectDrift: true
clockSyncUri: ""
disableXlinkProcessing: false
ignoreDrmInfo: false
ignoreEmptyAdaptationSet: false
ignoreMaxSegmentDuration: false
ignoreMinBufferTime: false
ignoreSuggestedPresentationDelay: false
initialSegmentLimit: 1000
keySystemsByURI: {urn:uuid:1077efec-c0b2-4d02-ace3-3c1e52e2fb4b: "org.w3.clearkey", urn:uuid:edef8ba9-79d6-4ace-a3c8-27dcd51d21ed: "com.widevine.alpha", urn:uuid:9a04f079-9840-4286-ab92-e65be0885f95: "com.microsoft.playready", urn:uuid:79f0049a-4098-8642-ab92-e65be0885f95: "com.microsoft.playready", urn:uuid:f239e769-efa3-4850-9c16-a903c6932efb: "com.adobe.primetime"}
manifestPreprocessor: ƒ (g)
xlinkFailGracefully: false
defaultPresentationDelay: 0
disableAudio: false
disableText: false
disableThumbnails: false
disableVideo: false
hls: {ignoreTextStreamFailures: false, ignoreImageStreamFailures: false, useFullSegmentsForStartTime: false}
retryParameters:
backoffFactor: 2
baseDelay: 1000
connectionTimeout: 10000
fuzzFactor: 0.5
maxAttempts: 2
stallTimeout: 5000
timeout: 30000
offline: {usePersistentLicense: true, trackSelectionCallback: ƒ, downloadSizeCallback: ƒ, progressCallback: ƒ}
playRangeEnd: Infinity
playRangeStart: 0
preferForcedSubs: false
preferredAudioChannelCount: 2
preferredAudioCodecs: []
preferredAudioLanguage: ""
preferredDecodingAttributes: []
preferredTextLanguage: ""
preferredTextRole: ""
preferredVariantRole: ""
preferredVideoCodecs: []
restrictions:
maxBandwidth: Infinity
maxFrameRate: Infinity
maxHeight: Infinity
maxPixels: Infinity
maxWidth: Infinity
minBandwidth: 0
minFrameRate: 0
minHeight: 0
minPixels: 0
minWidth: 0
streaming:
alwaysStreamText: false
autoLowLatencyMode: false
bufferBehind: 30
bufferingGoal: 10
durationBackoff: 1
failureCallback: ƒ (c)
forceHTTPS: false
forceTransmuxTS: false
gapDetectionThreshold: 0.5
ignoreTextStreamFailures: false
inaccurateManifestTolerance: 2
jumpLargeGaps: false
lowLatencyMode: false
preferNativeHls: false
rebufferingGoal: 2
retryParameters:
backoffFactor: 2
baseDelay: 1000
connectionTimeout: 10000
fuzzFactor: 0.5
maxAttempts: 2
stallTimeout: 5000
timeout: 30000
safeSeekOffset: 5
smallGapLimit: 0.5
stallEnabled: true
stallSkip: 0
stallThreshold: 1
startAtSegmentBoundary: false
updateIntervalSeconds: 1
useNativeHlsOnSafari: true
textDisplayFactory: ƒ ()

What did you do?

Player configured for DRM
Play a clear stream

What did you expect to happen?
Play clear stream without issue.

What actually happened?

3019 error reported
image

Traced this to d0da2d4
where Tizen and Xbox had special case handling added.

@joeyparrish
Copy link
Member

@msavvik, can you send a PR to handle avc3 and its encrypted equivalent?

@joeyparrish joeyparrish added type: bug Something isn't working correctly flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this priority: P1 Big impact or workaround impractical; resolve before feature release and removed needs triage labels Sep 9, 2021
@shaka-bot shaka-bot added this to the v3.3 milestone Sep 9, 2021
@david-hm-morgan
Copy link
Contributor Author

Well spotted @msavvik - thanks!
I'll create a PR targetting this.

@msavvik
Copy link

msavvik commented Sep 13, 2021 via email

@joeyparrish
Copy link
Member

@msavvik, we closed this issue with a PR from @david-hm-morgan. Please see #3625. But if you want to get permissions from your organization for other contributions in the future, we are always happy to have more people involved. Thanks!

joeyparrish pushed a commit that referenced this issue Sep 13, 2021
content_workarounds.js was introduced for Tizen and Xbox platforms. We found that that meant a regression where certain streams were unable to be played.

This PR adds ac-3 into the content workarounds in the same was as ec-3 to ensure these streams can be played once more.

Issue #3589
joeyparrish pushed a commit that referenced this issue Oct 12, 2021
content_workarounds.js was introduced for Tizen and Xbox platforms. We found that that meant a regression where certain streams were unable to be played.

This PR adds ac-3 into the content workarounds in the same was as ec-3 to ensure these streams can be played once more.

Issue #3589
joeyparrish pushed a commit that referenced this issue Oct 12, 2021
content_workarounds.js was introduced for Tizen and Xbox platforms. We found that that meant a regression where certain streams were unable to be played.

This PR adds ac-3 into the content workarounds in the same was as ec-3 to ensure these streams can be played once more.

Issue #3589
joeyparrish pushed a commit that referenced this issue Oct 12, 2021
content_workarounds.js was introduced for Tizen and Xbox platforms. We found that that meant a regression where certain streams were unable to be played.

This PR adds ac-3 into the content workarounds in the same was as ec-3 to ensure these streams can be played once more.

Issue #3589
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Nov 9, 2021
@shaka-project shaka-project locked and limited conversation to collaborators Nov 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants