Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avc3 added to content workarounds #3625

Merged
merged 1 commit into from
Sep 10, 2021
Merged

avc3 added to content workarounds #3625

merged 1 commit into from
Sep 10, 2021

Conversation

david-hm-morgan
Copy link
Contributor

Description

content_workarounds.js was introduced for Tizen and Xbox platforms. We found that that meant a regression where certain streams were unable to be played.

This PR adds avc3 into the content workarounds in the same was as avc1 to ensure these streams can be played once more.

Fixes #3589

Screenshots (optional)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

Checklist:

  • I have signed the Google CLA https://cla.developers.google.com
  • My code follows the style guidelines of this project
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have verified my change on multiple browsers on different platforms
  • I have run ./build/all.py and the build passes
  • I have run ./build/test.py and all tests pass

@shaka-bot
Copy link
Collaborator

All tests passed!

@joeyparrish joeyparrish merged commit 31b1ca9 into shaka-project:master Sep 10, 2021
@avelad avelad mentioned this pull request Sep 13, 2021
Merged
@joeyparrish joeyparrish mentioned this pull request Sep 13, 2021
Closed
joeyparrish pushed a commit that referenced this pull request Oct 12, 2021
@david-hm-morgan @joeyparrish
fix: Fix DRM workaround for Tizen and Xbox with avc3 boxes (#3625)
bbc3e9f 
The workaround previously only matched avc1 boxes.  This adds avc3 to the workaround, fixing content that uses this box on Tizen and Xbox.
joeyparrish pushed a commit that referenced this pull request Oct 12, 2021
@david-hm-morgan @joeyparrish
fix: Fix DRM workaround for Tizen and Xbox with avc3 boxes (#3625)
2090abd 
The workaround previously only matched avc1 boxes.  This adds avc3 to the workaround, fixing content that uses this box on Tizen and Xbox.
joeyparrish pushed a commit that referenced this pull request Oct 12, 2021
@david-hm-morgan @joeyparrish
fix: Fix DRM workaround for Tizen and Xbox with avc3 boxes (#3625)
7050fbe 
The workaround previously only matched avc1 boxes.  This adds avc3 to the workaround, fixing content that uses this box on Tizen and Xbox.
@david-hm-morgan david-hm-morgan deleted the fix/3589/avc3-content-workarounds branch October 14, 2021 06:19
@david-hm-morgan david-hm-morgan restored the fix/3589/avc3-content-workarounds branch October 16, 2021 16:25
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tizen unable to play clear when configured for DRM due to #2620 workaround
3 participants
@david-hm-morgan @shaka-bot @joeyparrish