-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shaka Player is displaying only one audio channel information even if manifest has Stereo + Dolby 5.1 + Dolby Atmos #4171
Comments
It seems that the DASH parser does the following: https://github.com/shaka-project/shaka-player/blob/main/lib/dash/dash_parser.js#L1220-L1234 In you manifest you have:
Until this is implemented codecs cannot be changed during the playback: #1528 Besides, a conversion is made for those with JOC and the Is this wrong for you? |
I understood that during playback Codec switching is not possible, but is there any preferences we can set for Atmos, when 5.1 and Atmos both are present in a single manifest, as currently 5.1 only being played. |
I think that what is being done in the parser is wrong, besides that in HLS it is not done. I will send a PR throughout the day to correct this. Thank you! |
According to https://developerkb.dolby.com/support/solutions/articles/16000067758-what-is-dolby-digital-plus-joc-joint-object-coding- Dolby Atmos (JOC): > Joint Object Coding describes the process by which Dolby Digital Plus with Atmos decoders, receiving a legacy 5.1 mix and sideband metadata, are able to reconstruct the original Atmos mix. So there is no need to deal with a separate mimetype, it can be decoded with Dolby Digital+ (better for retrocompatibility). Closes #4171
According to https://developerkb.dolby.com/support/solutions/articles/16000067758-what-is-dolby-digital-plus-joc-joint-object-coding- Dolby Atmos (JOC): > Joint Object Coding describes the process by which Dolby Digital Plus with Atmos decoders, receiving a legacy 5.1 mix and sideband metadata, are able to reconstruct the original Atmos mix. So there is no need to deal with a separate mimetype, it can be decoded with Dolby Digital+ (better for retrocompatibility). Closes #4171
According to https://developerkb.dolby.com/support/solutions/articles/16000067758-what-is-dolby-digital-plus-joc-joint-object-coding- Dolby Atmos (JOC): > Joint Object Coding describes the process by which Dolby Digital Plus with Atmos decoders, receiving a legacy 5.1 mix and sideband metadata, are able to reconstruct the original Atmos mix. So there is no need to deal with a separate mimetype, it can be decoded with Dolby Digital+ (better for retrocompatibility). Closes #4171
Have you read the FAQ and checked for duplicate open issues?
What version of Shaka Player are you using?
Can you reproduce the issue with our latest release version?
Can you reproduce the issue with the latest code from
main
?Are you using the demo app or your own custom app?
If custom app, can you reproduce the issue using our demo app?
What browser and OS are you using?
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
What are the manifest and license server URIs?
What configuration are you using? What is the output of
player.getConfiguration()
?What did you do?
What did you expect to happen?
What actually happened?
The text was updated successfully, but these errors were encountered: