Exception in v4.0.0 with streaming.startAtSegmentBoundary #4188
Assignees
Labels
priority: P1
Big impact or workaround impractical; resolve before feature release
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
Milestone
Comments
avelad
added
the
priority: P1
|
I have checked and it happens. Seems like a regression when removing deprecated code in 4.0. @joeyparrish , can you take a look at it? |
joeyparrish
changed the title
|
There are no tests that activate that code path! Fixing the code was easy. I'm adding tests now. PR coming soon. |
joeyparrish
changed the title
joeyparrish
added a commit
to joeyparrish/shaka-player
that referenced
this issue
May 11, 2022
v4.0.0 introduced a regression. When SegmentIterator's seek() method was removed, one reference to it was missed in Player. This was only used when streaming.startAtSegmentBoundary is true, and there were no tests to exercise that code path. This adds new tests and fixes the regression. Closes shaka-project#4188
joeyparrish
added a commit
that referenced
this issue
May 11, 2022
v4.0.0 introduced a regression. When SegmentIterator's seek() method was removed, one reference to it was missed in Player. This was only used when streaming.startAtSegmentBoundary is true, and there were no tests to exercise that code path. This adds new tests and fixes the regression. Closes #4188
This was referenced May 11, 2022
joeyparrish
added a commit
that referenced
this issue
May 17, 2022
v4.0.0 introduced a regression. When SegmentIterator's seek() method was removed, one reference to it was missed in Player. This was only used when streaming.startAtSegmentBoundary is true, and there were no tests to exercise that code path. This adds new tests and fixes the regression. Closes #4188
joeyparrish
added a commit
that referenced
this issue
May 17, 2022
v4.0.0 introduced a regression. When SegmentIterator's seek() method was removed, one reference to it was missed in Player. This was only used when streaming.startAtSegmentBoundary is true, and there were no tests to exercise that code path. This adds new tests and fixes the regression. Closes #4188
joeyparrish
added a commit
that referenced
this issue
May 17, 2022
v4.0.0 introduced a regression. When SegmentIterator's seek() method was removed, one reference to it was missed in Player. This was only used when streaming.startAtSegmentBoundary is true, and there were no tests to exercise that code path. This adds new tests and fixes the regression. Closes #4188
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Have you read the FAQ and checked for duplicate open issues?
yes
What version of Shaka Player are you using?
4.0.0
Can you reproduce the issue with our latest release version?
yes
Can you reproduce the issue with the latest code from
main?yes
Are you using the demo app or your own custom app?
custom
If custom app, can you reproduce the issue using our demo app?
no
What browser and OS are you using?
Firefox 99
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
What are the manifest and license server URIs?
What configuration are you using? What is the output of
player.getConfiguration()?This issue will ONLY occur if you set "streaming.startAtSegmentBoundary" to true.
What did you do?
call "load()"
What did you expect to happen?
video plays
What actually happened?
ERROR TypeError: k.segmentIndex[Symbol.iterator]().seek is not a functionshaka-player/lib/player.js
Line 5013 in 20ddf6a
calls "seek()" but that function has been removed in version 4.0
The text was updated successfully, but these errors were encountered: