-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression: New segments are not fetched after seeking until the player is out of buffer #5785
Comments
@wjywbs are you interested in create a PR for fix it? Thank you! |
I tested your page changing to https://nightly-dot-shaka-player-demo.appspot.com/dist/shaka-player.compiled.js and works fine, so the problem is fixed in the main branch. Can you try it? Thanks! |
I'm seeing the same behavior when using https://nightly-dot-shaka-player-demo.appspot.com/dist/shaka-player.compiled.js. When the video starts to play and I seek to a few seconds before the end of buffer, new segments are not fetched until the player is out of buffer. |
@wjywbs I have tried to reproduce it but I have not been able to, can you share a video of the Shaka demo just in case I do something wrong... |
Currently the nightly shaka player fails to play the video. Error: Cannot read properties of null (reading 'getIteratorForTime') I will record a video with shaka player v4.5.0 |
Here's a recording of this issue with shaka player v4.5.0: repro450.mp4 |
Can you test if with version 4.7.0 the problem still occurs? Thank you! |
Closing due to inactivity. If this is still an issue for you or if you have further questions, the OP can ask shaka-bot to reopen it by including |
v4.7.0 has the same issue in v4.5.0 @shaka-bot reopen |
Can you check if the error still occurs in version 4.7.4? Thank you! |
Yes, this issue still happens in v4.7.4 |
I have reproduced the issue, it only happens with the browser's native UI. But the problem is in the UI I think, because the getBufferedInfo API returns me the correct information (that is, the segments are downloaded). |
I comment out this line locally and this issue does not happen anymore. |
Have you read the FAQ and checked for duplicate open issues?
Yes
If the problem is related to FairPlay, have you read the tutorial?
Not related
What version of Shaka Player are you using?
v4.5.0
Can you reproduce the issue with our latest release version?
Yes
Can you reproduce the issue with the latest code from
main
?Yes
Are you using the demo app or your own custom app?
Custom app
If custom app, can you reproduce the issue using our demo app?
No
What browser and OS are you using?
Chrome on Mac
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
N/A
What are the manifest and license server URIs?
https://bitmovin-a.akamaihd.net/content/art-of-motion_drm/m3u8s/11331.m3u8
What configuration are you using? What is the output of
player.getConfiguration()
?What did you do?
I'm observing this issue in v4.5.0 and v4.4.0, but not in v4.3.0. Then I did a git bisect which pointed to commit c42565c.
Minimal repro with shaka player built at commit c42565c:
https://personal-data-2018.s3.amazonaws.com/shaka.html
What did you expect to happen?
Buffer should keep growing after seeking to near the location where the playback buffer ends.
What actually happened?
New segments are not fetched after seeking until the player is out of buffer.
The text was updated successfully, but these errors were encountered: