Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: New segments are not fetched after seeking until the player is out of buffer #5785

Closed
wjywbs opened this issue Oct 19, 2023 · 15 comments · Fixed by #6435 or #5987
Closed
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@wjywbs
Copy link
Contributor

wjywbs commented Oct 19, 2023

Have you read the FAQ and checked for duplicate open issues?
Yes

If the problem is related to FairPlay, have you read the tutorial?
Not related

What version of Shaka Player are you using?
v4.5.0

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from main?
Yes

Are you using the demo app or your own custom app?
Custom app

If custom app, can you reproduce the issue using our demo app?
No

What browser and OS are you using?
Chrome on Mac

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
N/A

What are the manifest and license server URIs?
https://bitmovin-a.akamaihd.net/content/art-of-motion_drm/m3u8s/11331.m3u8

What configuration are you using? What is the output of player.getConfiguration()?

{
  streaming: {
    rebufferingGoal: 5,
    bufferingGoal: 20
  }
}

What did you do?

I'm observing this issue in v4.5.0 and v4.4.0, but not in v4.3.0. Then I did a git bisect which pointed to commit c42565c.

Minimal repro with shaka player built at commit c42565c:
https://personal-data-2018.s3.amazonaws.com/shaka.html

What did you expect to happen?

Buffer should keep growing after seeking to near the location where the playback buffer ends.

What actually happened?

New segments are not fetched after seeking until the player is out of buffer.

@wjywbs wjywbs added the type: bug Something isn't working correctly label Oct 19, 2023
@shaka-bot shaka-bot added this to the v4.6 milestone Oct 19, 2023
@avelad
Copy link
Member

avelad commented Oct 23, 2023

@wjywbs are you interested in create a PR for fix it? Thank you!

@avelad avelad added the priority: P1 Big impact or workaround impractical; resolve before feature release label Oct 23, 2023
@wjywbs
Copy link
Contributor Author

wjywbs commented Oct 23, 2023

Hi @avelad, I don't understand how c42565c causes this regression. c42565c is supposed to fix the AV sync issue in #4589.

@avelad
Copy link
Member

avelad commented Oct 30, 2023

I tested your page changing to https://nightly-dot-shaka-player-demo.appspot.com/dist/shaka-player.compiled.js and works fine, so the problem is fixed in the main branch. Can you try it? Thanks!

@avelad avelad added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Oct 30, 2023
@wjywbs
Copy link
Contributor Author

wjywbs commented Oct 30, 2023

I'm seeing the same behavior when using https://nightly-dot-shaka-player-demo.appspot.com/dist/shaka-player.compiled.js. When the video starts to play and I seek to a few seconds before the end of buffer, new segments are not fetched until the player is out of buffer.

@shaka-bot shaka-bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Oct 30, 2023
@avelad
Copy link
Member

avelad commented Oct 31, 2023

@wjywbs I have tried to reproduce it but I have not been able to, can you share a video of the Shaka demo just in case I do something wrong...

@avelad avelad added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Nov 7, 2023
@wjywbs
Copy link
Contributor Author

wjywbs commented Nov 8, 2023

Currently the nightly shaka player fails to play the video. Error: Cannot read properties of null (reading 'getIteratorForTime')

https://nightly-dot-shaka-player-demo.appspot.com/demo/#audiolang=en-US;textlang=en-US;uilang=en-US;asset=https://bitmovin-a.akamaihd.net/content/art-of-motion_drm/m3u8s/11331.m3u8;panel=CUSTOM%20CONTENT;build=uncompiled

I will record a video with shaka player v4.5.0

@shaka-bot shaka-bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Nov 8, 2023
@avelad
Copy link
Member

avelad commented Nov 8, 2023

@wjywbs I fixed Error: Cannot read properties of null (reading 'getIteratorForTime') in #5871

@wjywbs
Copy link
Contributor Author

wjywbs commented Nov 8, 2023

Here's a recording of this issue with shaka player v4.5.0:

repro450.mp4

avelad added a commit that referenced this issue Nov 8, 2023
@avelad avelad modified the milestones: v4.6, v5.0 Nov 16, 2023
Robloche pushed a commit to Robloche/shaka-player that referenced this issue Nov 30, 2023
@avelad avelad modified the milestones: v4.7, v5.0 Dec 4, 2023
@avelad
Copy link
Member

avelad commented Dec 4, 2023

Can you test if with version 4.7.0 the problem still occurs? Thank you!

@avelad avelad added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Dec 4, 2023
@shaka-bot
Copy link
Collaborator

Closing due to inactivity. If this is still an issue for you or if you have further questions, the OP can ask shaka-bot to reopen it by including @shaka-bot reopen in a comment.

@shaka-bot shaka-bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Dec 11, 2023
@wjywbs
Copy link
Contributor Author

wjywbs commented Dec 11, 2023

v4.7.0 has the same issue in v4.5.0

@shaka-bot reopen

@shaka-bot shaka-bot reopened this Dec 11, 2023
@avelad
Copy link
Member

avelad commented Jan 15, 2024

Can you check if the error still occurs in version 4.7.4? Thank you!

@avelad avelad added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Jan 15, 2024
@wjywbs
Copy link
Contributor Author

wjywbs commented Jan 15, 2024

Yes, this issue still happens in v4.7.4

@shaka-bot shaka-bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Jan 15, 2024
@avelad
Copy link
Member

avelad commented Jan 31, 2024

I have reproduced the issue, it only happens with the browser's native UI. But the problem is in the UI I think, because the getBufferedInfo API returns me the correct information (that is, the segments are downloaded).

@wjywbs
Copy link
Contributor Author

wjywbs commented Feb 1, 2024

I comment out this line locally and this issue does not happen anymore.

@avelad avelad added the component: HLS The issue involves Apple's HLS manifest format label Apr 10, 2024
theodab pushed a commit that referenced this issue Apr 11, 2024
This reverts #4886, which was found to cause issues with fetching segments after seeking.

Closes #5785
Re-open #4589
avelad added a commit that referenced this issue Apr 15, 2024
This reverts #4886, which was found to cause issues with fetching segments after seeking.

Closes #5785
Re-open #4589
avelad added a commit that referenced this issue Apr 15, 2024
This reverts #4886, which was found to cause issues with fetching segments after seeking.

Closes #5785
Re-open #4589
joeyparrish pushed a commit that referenced this issue May 7, 2024
This reverts #4886, which was found to cause issues with fetching segments after seeking.

Closes #5785
Re-open #4589
joeyparrish pushed a commit that referenced this issue May 7, 2024
This reverts #4886, which was found to cause issues with fetching segments after seeking.

Closes #5785
Re-open #4589
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jun 10, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
3 participants