Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Export d ts as a module #4163

Merged
merged 2 commits into from
Apr 26, 2022
Merged

fix: Export d ts as a module #4163

merged 2 commits into from
Apr 26, 2022

Conversation

cemsina
Copy link
Contributor

@cemsina cemsina commented Apr 26, 2022 •
edited by joeyparrish
Loading

Missing module export added

BEGIN_COMMIT_OVERRIDE
fix: Add missing module export in generated typescript defs
END_COMMIT_OVERRIDE

@cemsina
Export d ts as module
829adb2 
Missing module export added
@cemsina cemsina changed the title Export d ts as a module fix: Export d ts as a module Apr 26, 2022
joeyparrish
joeyparrish requested changes Apr 26, 2022
View reviewed changes
build/generateTsDefs.py Outdated Show resolved Hide resolved
@joeyparrish joeyparrish merged commit feefd7b into shaka-project:main Apr 26, 2022
@github-actions github-actions bot mentioned this pull request Apr 26, 2022
Merged
joeyparrish pushed a commit that referenced this pull request Apr 26, 2022
@cemsina @joeyparrish
fix: Add missing module export in generated typescript defs (#4163)
90fa6a7 
Missing module export added
@github-actions github-actions bot mentioned this pull request Apr 26, 2022
Merged
joeyparrish pushed a commit that referenced this pull request Apr 26, 2022
@cemsina @joeyparrish
fix: Add missing module export in generated typescript defs (#4163)
3dc10d4 
Missing module export added
joeyparrish pushed a commit that referenced this pull request Apr 26, 2022
@cemsina @joeyparrish
fix: Add missing module export in generated typescript defs (#4163)
164e601 
Missing module export added
This was referenced Apr 26, 2022
Merged
Merged
@joeyparrish joeyparrish mentioned this pull request Apr 28, 2022
Closed
@joeyparrish
Copy link
Member

This appears to have caused #4167, so I will revert it.

joeyparrish added a commit that referenced this pull request Apr 29, 2022
@joeyparrish
Revert "fix: Export d ts as a module (#4163)"
61cfbbb 
This reverts commit feefd7b.
@joeyparrish joeyparrish mentioned this pull request Apr 29, 2022
Merged
joeyparrish added a commit that referenced this pull request Apr 29, 2022
@joeyparrish
fix: Revert "Add missing module export in generated typescript defs" (#…
fe4f5c6 
…4175)

Reverts #4163

Closes #4167
joeyparrish added a commit that referenced this pull request May 17, 2022
@joeyparrish
fix: Revert "Add missing module export in generated typescript defs" (#…
763e932 
…4175)

Reverts #4163

Closes #4167
joeyparrish added a commit that referenced this pull request May 17, 2022
@joeyparrish
fix: Revert "Add missing module export in generated typescript defs" (#…
c44507a 
…4175)

Reverts #4163

Closes #4167
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cemsina @joeyparrish