Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module import error #4167

Closed
frankykubo opened this issue Apr 27, 2022 · 4 comments · Fixed by #4175 or #4009
Closed

Module import error #4167

frankykubo opened this issue Apr 27, 2022 · 4 comments · Fixed by #4175 or #4009
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@frankykubo
Copy link

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
3.3.4

Can you reproduce the issue with our latest release version?
There is no need

Can you reproduce the issue with the latest code from main?
There is no need

Are you using the demo app or your own custom app?
Custom app

If custom app, can you reproduce the issue using our demo app?
Probably, but there is no need.

What browser and OS are you using?
Chrome canary 103.0.5026.0, Windows 10

What did you do?
Updated from version 3.3.3 to version 3.3.4

What did you expect to happen?
No import errors.

What actually happened?
App is not able to import shaka anymore in this version, attaching picture below.

shaka_err

When I go back to v 3.3.3, it works as expected.
Thank you.

@frankykubo frankykubo added the type: bug Something isn't working correctly label Apr 27, 2022
@github-actions github-actions bot added this to the v3.3 milestone Apr 27, 2022
@joeyparrish
Copy link
Member

v3.3.4 contained this PR: #4163

Do you think that could explain the issue? What happens if you remove that added line from the d.ts file?

@joeyparrish
Copy link
Member

There were not many other changes in v3.3.4 compared to v3.3.3: v3.3.3...v3.3.4

The other changes were CSS, CI, and documentation changes.

@frankykubo
Copy link
Author

@joeyparrish Yes, you are right. Removing export default shaka; from shaka-player.compiled.d.ts file fixes the error.

@joeyparrish
Copy link
Member

Thank you for confirming. I will revert the PR that caused this.

@avelad avelad modified the milestones: v3.3, v4.0 May 4, 2022
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jun 28, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
3 participants