-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module import error #4167
Comments
v3.3.4 contained this PR: #4163 Do you think that could explain the issue? What happens if you remove that added line from the d.ts file? |
There were not many other changes in v3.3.4 compared to v3.3.3: v3.3.3...v3.3.4 The other changes were CSS, CI, and documentation changes. |
@joeyparrish Yes, you are right. Removing |
Thank you for confirming. I will revert the PR that caused this. |
Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
3.3.4
Can you reproduce the issue with our latest release version?
There is no need
Can you reproduce the issue with the latest code from
main
?There is no need
Are you using the demo app or your own custom app?
Custom app
If custom app, can you reproduce the issue using our demo app?
Probably, but there is no need.
What browser and OS are you using?
Chrome canary 103.0.5026.0, Windows 10
What did you do?
Updated from version 3.3.3 to version 3.3.4
What did you expect to happen?
No import errors.
What actually happened?
App is not able to import shaka anymore in this version, attaching picture below.
When I go back to v 3.3.3, it works as expected.
Thank you.
The text was updated successfully, but these errors were encountered: