Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@sync-ignore proxy setting double slash gets lost #865

Closed
bjonen opened this issue Apr 29, 2019 · 1 comment
Closed

@sync-ignore proxy setting double slash gets lost #865

bjonen opened this issue Apr 29, 2019 · 1 comment
Labels
bug 🐛 fixed
Milestone
v3.3.0

Comments

@bjonen
Copy link

bjonen commented Apr 29, 2019

🐛 Describe the bug

My settings.json looks like this:
// @sync-ignore
"http.proxy": "http://user:pw@myproxy:port",
// @sync-ignore
"http.proxyStrictSSL": false,

When download my laptop settings to my office computer, the settings.json gets rewritten but the http proxy becomes http:user:pw@myproxy:port (missing the "//") so that all extension downloads fail afterwards.

🌴 Visual Studio Code Version : 1.331
@protiumx
Copy link
Contributor

protiumx commented May 2, 2019

@shanalikhan I will take this

@protiumx protiumx mentioned this issue May 2, 2019
Closed
@shanalikhan shanalikhan mentioned this issue May 2, 2019
Closed
@protiumx protiumx mentioned this issue May 3, 2019
Merged
@93Akkord 93Akkord mentioned this issue May 5, 2019
Merged
1 task
@shanalikhan shanalikhan added this to the v3.3.0 milestone May 6, 2019
@shanalikhan shanalikhan mentioned this issue May 6, 2019
Closed
@shanalikhan shanalikhan modified the milestones: v3.3.0, Backlog Jun 6, 2019
@shanalikhan shanalikhan modified the milestones: Backlog, v3.3.0 Jun 24, 2019
shanalikhan pushed a commit that referenced this issue Jun 24, 2019
@protiumx @shanalikhan
#754 and #865
c0ee128 
* Fix #754

The pragma util keeps a copy of the settings that are upload to the
gist. The file is located at <context.globalStoragePath>/settings.sync.

If the content to be upload doesn't deffer from the local content after
taking out the @sync-ignore, the file wont be uploaded.

* Fix #754: Sync object

Checks the global storage path at constructor.
Checks if the content of the setting file should be uploaded.

* Update tests

* Fix #865

* Fix broken tests

* Fixing Octokit wrong type for GistsResponse

'file' field is wrong with static data.

* Defining PragmaUtil behavior

Pragma util should only parse string content, checking each line for pragma statements.

* Updating test for Pragma definition

* Sync: don't upload is not necessary

As the extension gets the entire gists before commiting an upload, we can check each file of the gists against our local files in order to determine if the content has changed.

There is no need to keel a local copy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 fixed
Projects
None yet
Milestone
v3.3.0
Development

No branches or pull requests
3 participants
@bjonen @shanalikhan @protiumx