Cleaned up toggling commented settings #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
shanalikhan
pushed a commit
that referenced
this pull request
Jun 24, 2019
* Cleaned up toggling commented settings * Updated to include fix by @ioprotium
shanalikhan
pushed a commit
that referenced
this pull request
Jul 1, 2019
* Updated to task api 2.0.0 and fixed tests * Set "extensionKind": "ui" to support remote development #61 Fixes #870. See that issue for details * Clean up previous commits into one * #800 #515 #854 * Utilized pragmaUtil Functions for kb.json file * Typo fix * Added universalKeybindings setting * chore(package): update @types/node to version 12.0.0 (#873) * Cleaned up toggling commented settings (#877) * Cleaned up toggling commented settings * Updated to include fix by @ioprotium * Fix warning with webpack * Update UI * Change height to max-height * Add image locally and move it to the top * Added documentation for tests in CONTRIBUTING.md (#881) * fix(package): update fs-extra to version 8.0.0 (#882) * chore(package): update @types/fs-extra to version 7.0.0 (#885) * chore(package): update @types/node to version 12.0.1 (#883) * fix(package): update fs-extra to version 8.0.1 (#884) * Update UI to fit guidelines * chore(package): update @types/node to version 12.0.2 (#887) * Improve UI and functionality * Match BG of theme and properly contrast text * Fix issues with themes * Fix image not showing up with light theme * Fix issues with contrast * Fix issue with VS Code's WebView * Update UI and functionality * Fix potential issue with light themes * Fix issues with theme on modal * Refactor * Add new (but experimental) localizations (#898) * chore(package): update clean-webpack-plugin to version 3.0.0 (#899) * #891 * Update settings page after a reset * Improve code * fix(clean-webpack-plugin): (#901) clean-webpack-plugin was recently updated, and it had breaking changes. * chore(package): update @types/node to version 12.0.3 (#897) * #668 * fix(OSS): enums.ts ---- Allow for setting os type with less code environmentPath.ts ---- Find code folder and extensions folder more efficiently Get OS type more efficiently settings.ts ---- Ignore all state files sync.ts ---- Adapt for changes in pluginService pluginService.ts ---- Use vscode command to install extensions Clean up code and simplify names * Install extensions in order * Comment legacy code instead of deleting it * Fix extension install * Fix issue with extensions always being deleted * Get code path more efficiently * Make sure to escape spaces in cli path * Fix issues with portable builds * Support Windows and certain editions * Improve method for finding extension folder * Start using API for installation * Prepare for new API command * Get ready for new API command * Fix issue with installation * Commit requested changes * #668 * Format pluginService.ts (#906) * #668 * Throw error * Try to fix issues with getting missing * chore(package): update @types/node to version 12.0.7 (#904) * chore(package): update @types/node to version 12.0.8 (#908) * #668 * #668 * #668 * #839 * Support multiple instances * Completely switch to state * Update to work properly * Move setting classes to their own models * Update service names * Only auto upload using focused window * Resolve merge conflicts * #886 * Resolve locale properly * Clean constructor * Use state instead of passing in argument * Update to be compatible with v3.3.0 changes * Fix readme * Fix package.json * Add new settings * Increase contrast * Update package.nls.*.json ---- Add localizations for setting names and placeholders. github.oauth.service.ts ---- Handle errors in a more user-facing way Support GitHub enterprise Show message to user after success webview.service.ts ---- Use new localizations for names and placeholders * Bug fix and upload images * Add support for commits to master (release notes) * Fix issue * Fix another issue with release notes * Update release note template * Update release notes * Don't open gist selection if there aren't any gists * Allow user to view gist * Revert accidental change * Support public gist * Add css, js, and fonts to repo * Improve font injection * Revert accidental change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Checklist: