enable strict mode #350
Merged
enable strict mode #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/shapeshift/hdwallet/9toz94VFUsh74mg2xvBY1WQcseQs |
Merged
mrnerdhair
force-pushed
the
strict_mode_no_really
branch
from
0c1ff16
to
3d3cbeb
Compare
mrnerdhair
force-pushed
the
strict_mode_no_really
branch
from
3d3cbeb
to
83c777c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off of #349.
This cleans up the last few things required to enable strict mode for the whole repo, including integration tests. (Mostly just a bunch of extra
core.mustBeDefined's and some optional chaining.)