-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor various architectural things #354
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/shapeshift/hdwallet/3DcPFVTt8V3ZXgL3LU7EyicAZz6d |
this @peculiar/webcrypto patch is blowing up my world. |
and why are we patching my own package :( |
running on node v16.6.2 |
91d7a45
to
c2c4e40
Compare
c2c4e40
to
50a62a6
Compare
50a62a6
to
a7b8d10
Compare
So that error is the exact thing the patch is supposed to fix -- are you sure patch-package is being run properly? |
closing as stale. @mrnerdhair - please re-open as necessary. |
Based on #350 and #351.
With the advent of web v2, we have an opportunity to make a breaking API change and release an hdwallet 2.0. This is a collection of a bunch of stuff that would be nice to do, at least some of which changes the external API enough that it'll probably break an existing client.
This isn't done yet, but it's ready for some comments.