Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor various architectural things #354

Closed
wants to merge 19 commits into from
Closed

Conversation

mrnerdhair
Copy link
Contributor

Based on #350 and #351.

With the advent of web v2, we have an opportunity to make a breaking API change and release an hdwallet 2.0. This is a collection of a bunch of stuff that would be nice to do, at least some of which changes the external API enough that it'll probably break an existing client.

This isn't done yet, but it's ready for some comments.

@vercel
Copy link

vercel bot commented Oct 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shapeshift/hdwallet/3DcPFVTt8V3ZXgL3LU7EyicAZz6d
✅ Preview: https://hdwallet-git-architecture-refactor-shapeshift.vercel.app

@BitHighlander
Copy link
Contributor

BitHighlander commented Oct 19, 2021

this @peculiar/webcrypto patch is blowing up my world. node_modules/@peculiar/webcrypto/index.d.ts:5:10 - error TS2416: Property 'getRandomValues' in type 'Crypto' is not assignable to the same property in base type 'Crypto'. Type '<T extends Int8Array | Uint8Array | Uint8ClampedArray | Int16Array | Uint16Array | Int32Array | ... 4 more ... | null>(array: T) => T' is not assignable to type '<T extends ArrayBufferView | null>(array: T) => T'. Types of parameters 'array' and 'array' are incompatible. debugging this after pulling in your code down into my fork. ```

@BitHighlander
Copy link
Contributor

and why are we patching my own package :( @bithighlander/bitcoin-cash-js-lib submit a pr! ill merge!

@BitHighlander
Copy link
Contributor

running on node v16.6.2

@mrnerdhair
Copy link
Contributor Author

this @peculiar/webcrypto patch is blowing up my world.

So that error is the exact thing the patch is supposed to fix -- are you sure patch-package is being run properly?

@0xean
Copy link
Contributor

0xean commented Jan 27, 2022

closing as stale. @mrnerdhair - please re-open as necessary.

@0xean 0xean closed this Jan 27, 2022
@mrnerdhair mrnerdhair mentioned this pull request Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants