Skip to content

Commit

Permalink
feat(shorebird_cli): shorebird preview outputs apks path (#2587)
Browse files Browse the repository at this point in the history
  • Loading branch information
felangel authored Oct 28, 2024
1 parent 5da13a5 commit 5d33b25
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
3 changes: 2 additions & 1 deletion packages/shorebird_cli/lib/src/commands/preview_command.dart
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,8 @@ class PreviewCommand extends ShorebirdCommand {
final buildApksProgress = logger.progress('Building apks');
try {
await bundletool.buildApks(bundle: aabFile.path, output: apksPath);
buildApksProgress.complete();
final apksLink = link(uri: Uri.parse(apksPath));
buildApksProgress.complete('Built apks: ${cyan.wrap(apksLink)}');
} catch (error) {
buildApksProgress.fail('$error');
return ExitCode.software.code;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -443,6 +443,14 @@ void main() {
});
});

test('outputs apks path', () async {
await runWithOverrides(command.run);
final apksLink = link(uri: Uri.parse(apksPath()));
verify(
() => progress.complete('Built apks: ${cyan.wrap(apksLink)}'),
).called(1);
});

test('does not prompt for platform, uses android', () async {
await runWithOverrides(command.run);

Expand Down

0 comments on commit 5d33b25

Please sign in to comment.