Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shorebird_cli): shorebird preview outputs apks path #2587

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

felangel
Copy link
Contributor

Description

Sample Output

✓ Fetching releases (0.2s)
✓ Fetching releases (0.2s)
Which release would you like to preview? 1.0.0+1
Which platform would you like to preview? Android
✓ Fetching aab artifact (0.1s)
✓ Downloading release (0.1s)
✓ Using production track (0.2s)
✓ Extracting metadata (0.5s)
✓ Built apks: /Users/felix/Development/github.com/shorebirdtech/_shorebird/shorebird/bin/cache/previews/16283cf1-89f6-46c0-a526-eaeefdbdfde3/android_1.0.0+1_463753.apks (2.7s)
✓ Installing apks (1.9s)
✓ Starting app (0.5s)
--------- beginning of main
10-28 14:32:30.577  5335  5335 I flutter : updater::cache::updater_state: No existing state file found: File /data/user/0/dev.shorebird.example/files/shorebird_updater/state.json does not exist, creating new state.

10-28 14:32:30.581  5335  5335 I flutter : [INFO:flutter/shell/common/shorebird/shorebird.cc(161)] Shorebird updater: no active patch.

10-28 14:32:30.581  5335  5335 I flutter : updater::updater: Reporting launch start.

10-28 14:32:30.581  5335  5335 I flutter : [INFO:flutter/shell/common/shorebird/shorebird.cc(184)] Starting Shorebird update

10-28 14:32:30.584  5335  5361 I flutter : updater::network: Sending patch check request: PatchCheckRequest { app_id: "16283cf1-89f6-46c0-a526-eaeefdbdfde3", channel: "stable", release_version: "1.0.0+1", platform: "android", arch: "aarch64" }

10-28 14:32:30.619  5335  5335 I flutter : updater::updater: Reporting successful launch.

10-28 14:32:30.711  5335  5361 I flutter : updater::updater: Patch check response: PatchCheckResponse { patch_available: true, patch: Some(Patch { number: 2, hash: "f5e127d0c52d0ad25a44193661df8b69731651f9dd28c03eab33f84c4bf74e9f", download_url: "https://cdn.shorebird.cloud/api/v1/patches/16283cf1-89f6-46c0-a526-eaeefdbdfde3/android/aarch64/110971/dlc.vmcode", hash_signature: None }), rolled_back_patch_numbers: Some([]) }

10-28 14:32:30.995  5335  5361 I flutter : updater::updater: Patch 2 successfully downloaded. It will be launched when the app next restarts.

10-28 14:32:30.996  5335  5361 I flutter : updater::updater: Update thread finished with status: Update installed

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore
  • 🧪 Tests

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@felangel
Copy link
Contributor Author

Will wait for @bryanoltman to take a look before either merging/closing this

@bryanoltman
Copy link
Contributor

Putting on my user hat, I think if I were to go looking for a way to generate an apk for an existing release, preview would be a really odd place to look, so I think having both this and #2586 is probably good. Will do re: refactoring.

@felangel
Copy link
Contributor Author

felangel commented Oct 28, 2024

Putting on my user hat, I think if I were to go looking for a way to generate an apk for an existing release, preview would be a really odd place to look, so I think having both this and #2586 is probably good. Will do re: refactoring.

Yeah agreed the only thing I would question is whether we get enough users asking to download an apk for it to justify adding a new command. Do we know what the use-case for generating an apk from an existing release is? We already allow you to generate an apk when creating a release so I'm not sure I understand the problem we're solving.

@felangel felangel merged commit 5d33b25 into main Oct 28, 2024
11 checks passed
@felangel felangel deleted the feat/shorebird-cli-output-apk-path-preview branch October 28, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants