Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(shorebird_cli): shorebird preview outputs apks path #2587

Merged
merged 2 commits into from
Oct 28, 2024
+10 −1
Merged

feat(shorebird_cli): shorebird preview outputs apks path #2587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8a015f
feat(shorebird_cli): `shorebird preview` outputs apks path
felangel Oct 28, 2024
be6171c
make test more strict
felangel Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/shorebird_cli/lib/src/commands/preview_command.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,8 @@ class PreviewCommand extends ShorebirdCommand {
final buildApksProgress = logger.progress('Building apks');
try {
await bundletool.buildApks(bundle: aabFile.path, output: apksPath);
buildApksProgress.complete();
final apksLink = link(uri: Uri.parse(apksPath));
buildApksProgress.complete('Built apks: ${cyan.wrap(apksLink)}');
} catch (error) {
buildApksProgress.fail('$error');
return ExitCode.software.code;
Expand Down
8 changes: 8 additions & 0 deletions packages/shorebird_cli/test/src/commands/preview_command_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,6 +443,14 @@ void main() {
});
});

test('outputs apks path', () async {
await runWithOverrides(command.run);
final apksLink = link(uri: Uri.parse(apksPath()));
verify(
() => progress.complete('Built apks: ${cyan.wrap(apksLink)}'),
).called(1);
});

test('does not prompt for platform, uses android', () async {
await runWithOverrides(command.run);

Expand Down
Loading