fix: fix azure portion of cloud uploader #7562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro11net
force-pushed
the
azure-upload-fix
branch
3 times, most recently
from
42ea2c6
to
7084f3e
Compare
smira
reviewed
Aug 2, 2023
ro11net
force-pushed
the
azure-upload-fix
branch
3 times, most recently
from
ccb7692
to
7888ab9
Compare
|
/promote integration-cloud-images |
ro11net
force-pushed
the
azure-upload-fix
branch
from
7888ab9
to
9f4c2d0
Compare
|
/promote integration-cloud-images |
ro11net
force-pushed
the
azure-upload-fix
branch
2 times, most recently
from
e4ddf28
to
7166b0c
Compare
smira
approved these changes
Aug 3, 2023
ro11net
force-pushed
the
azure-upload-fix
branch
2 times, most recently
from
180a86c
to
ae89dcb
Compare
Correctly propagate errors back. Drop ARM templates and use native APIs. Correctly handle restarted runs for creating image versions. fixes siderolabs#7512. Signed-off-by: Christian Rolland <[email protected]>
ro11net
force-pushed
the
azure-upload-fix
branch
from
ae89dcb
to
ac2aff5
Compare
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly propagate errors back. Drop ARM templates and use native APIs. Correctly handle restarted runs for creating image versions.
Pull Request
What? (description)
Why? (reasoning)
Acceptance
Please use the following checklist:
make conformance)make fmt)make lint)make docs)make unit-tests)