-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core/pane-layout): remove absolute positioning #1457
base: release-3.0.0
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 4c6fdc1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could come up with a more descriptive name for the added test case. I am afraid that six months from now no one will know what was tested. Maybe instead of "relative" something like "responsive" could work?
a5243a8
to
967f627
Compare
Co-authored-by: AndreasBerliner <[email protected]>
Co-authored-by: Daniel Leroux <[email protected]>
Co-authored-by: Daniel Leroux <[email protected]>
Co-authored-by: AndreasBerliner <[email protected]> Co-authored-by: Daniel Leroux <[email protected]>
Co-authored-by: Betti <[email protected]> Co-authored-by: tokyojen <[email protected]>
Co-authored-by: matthias <[email protected]>
#1476) Co-authored-by: Daniel Leroux <[email protected]>
Co-authored-by: Schnugg, Markus Wilhelm (T UX PAP-DE) <[email protected]>
Co-authored-by: Daniel Leroux <[email protected]>
# Conflicts: # .npmrc # packages/angular-test-app/package.json # packages/angular-test-app/src/preview-examples/echarts-special-zoom.ts # packages/angular/common/src/providers/toast/index.ts # packages/core/package.json # packages/core/scripts/e2e/load-e2e-runtime.js # packages/core/src/components/dropdown/test/dropdown.ct.ts # packages/core/src/components/modal/test/modal.ct.ts # packages/core/src/components/upload/upload.tsx # packages/core/src/components/utils/menu-tabs/menu-tabs-fc.tsx # packages/core/src/tests/card-list/card-list.e2e.ts-snapshots/card-list-basic-layout-scrolling-1-chromium---theme-classic-light-linux.png # packages/core/src/tests/card-list/card-list.e2e.ts-snapshots/card-list-basic-layout-scrolling-end-1-chromium---theme-classic-light-linux.png # packages/core/src/tests/card-list/card-list.e2e.ts-snapshots/card-list-basic-should-hide-show-all-button-1-chromium---theme-classic-dark-linux.png # packages/core/src/tests/card-list/card-list.e2e.ts-snapshots/card-list-basic-should-hide-show-all-button-1-chromium---theme-classic-light-linux.png # packages/core/src/tests/card-list/card-list.e2e.ts-snapshots/card-list-basic-should-not-have-visual-regressions-1-chromium---theme-classic-light-linux.png # packages/core/src/tests/checkbox/checkbox.e2e.ts-snapshots/checkbox-basic-1-chromium---theme-classic-dark-linux.png # packages/core/src/tests/checkbox/checkbox.e2e.ts-snapshots/checkbox-basic-1-chromium---theme-classic-light-linux.png # packages/core/src/tests/utils/test/page.ts # packages/core/stencil.config.ts # packages/documentation/package.json # packages/html-test-app/package.json # packages/react-test-app/package.json # packages/react-test-app/src/preview-examples/echarts-special-zoom.tsx # packages/vue-test-app/package.json # pnpm-lock.yaml
Quality Gate passedIssues Measures |
💡 What is the current behavior?
GitHub Issue Number: Closes #1305, [IX-1322]
🆕 What is the new behavior?
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm run docs
)pnpm test
)pnpm lint
)pnpm build
, changes pushed)👨💻 Help & support