Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/pane-layout): remove absolute positioning #1457

Open
wants to merge 30 commits into
base: release-3.0.0
Choose a base branch
from

Conversation

matthiashader
Copy link
Collaborator

@matthiashader matthiashader commented Sep 4, 2024

💡 What is the current behavior?

  • pane-layout is positioned absolute, despite being inside a div with height/width restriction it takes the whole screen
  • workaround is to overwrite the positioned: absolute css prop

GitHub Issue Number: Closes #1305, [IX-1322]

🆕 What is the new behavior?

  • position of the pane-layout is relative
  • default it takes 100% height / 100% width

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Sep 4, 2024

🦋 Changeset detected

Latest commit: 4c6fdc1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@siemens/ix Major
@siemens/ix-aggrid Patch
@siemens/ix-angular Major
@siemens/ix-react Major
@siemens/ix-vue Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@matthiashader matthiashader marked this pull request as draft September 4, 2024 10:45
@matthiashader matthiashader marked this pull request as ready for review September 4, 2024 12:17
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change IMO.

@matthiashader matthiashader added the V3 Will be part of the upcoming v3 release label Sep 12, 2024
@nuke-ellington nuke-ellington added this to the 3.0.0 milestone Sep 12, 2024
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could come up with a more descriptive name for the added test case. I am afraid that six months from now no one will know what was tested. Maybe instead of "relative" something like "responsive" could work?

@matthiashader matthiashader changed the base branch from main to v3 September 16, 2024 05:36
@danielleroux danielleroux changed the base branch from v3 to release-3.0.0 September 17, 2024 05:48
@matthiashader matthiashader force-pushed the fix/1322-pane-layout branch 3 times, most recently from a5243a8 to 967f627 Compare September 18, 2024 07:15
danielleroux and others added 11 commits September 25, 2024 11:37
# Conflicts:
#	.npmrc
#	packages/angular-test-app/package.json
#	packages/angular-test-app/src/preview-examples/echarts-special-zoom.ts
#	packages/angular/common/src/providers/toast/index.ts
#	packages/core/package.json
#	packages/core/scripts/e2e/load-e2e-runtime.js
#	packages/core/src/components/dropdown/test/dropdown.ct.ts
#	packages/core/src/components/modal/test/modal.ct.ts
#	packages/core/src/components/upload/upload.tsx
#	packages/core/src/components/utils/menu-tabs/menu-tabs-fc.tsx
#	packages/core/src/tests/card-list/card-list.e2e.ts-snapshots/card-list-basic-layout-scrolling-1-chromium---theme-classic-light-linux.png
#	packages/core/src/tests/card-list/card-list.e2e.ts-snapshots/card-list-basic-layout-scrolling-end-1-chromium---theme-classic-light-linux.png
#	packages/core/src/tests/card-list/card-list.e2e.ts-snapshots/card-list-basic-should-hide-show-all-button-1-chromium---theme-classic-dark-linux.png
#	packages/core/src/tests/card-list/card-list.e2e.ts-snapshots/card-list-basic-should-hide-show-all-button-1-chromium---theme-classic-light-linux.png
#	packages/core/src/tests/card-list/card-list.e2e.ts-snapshots/card-list-basic-should-not-have-visual-regressions-1-chromium---theme-classic-light-linux.png
#	packages/core/src/tests/checkbox/checkbox.e2e.ts-snapshots/checkbox-basic-1-chromium---theme-classic-dark-linux.png
#	packages/core/src/tests/checkbox/checkbox.e2e.ts-snapshots/checkbox-basic-1-chromium---theme-classic-light-linux.png
#	packages/core/src/tests/utils/test/page.ts
#	packages/core/stencil.config.ts
#	packages/documentation/package.json
#	packages/html-test-app/package.json
#	packages/react-test-app/package.json
#	packages/react-test-app/src/preview-examples/echarts-special-zoom.tsx
#	packages/vue-test-app/package.json
#	pnpm-lock.yaml
@siemens siemens deleted a comment from github-actions bot Oct 22, 2024
Copy link

sonarcloud bot commented Oct 23, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V3 Will be part of the upcoming v3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pane component does not respect parent size
6 participants