Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/pane-layout): remove absolute positioning #1457

Open
wants to merge 30 commits into
base: release-3.0.0
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
1ef1af5
fix(core/pane-layout): remove absolute positioning
matthiashader Sep 4, 2024
4fc1913
chore: changeset
matthiashader Sep 4, 2024
06f19da
fix: add vrts
matthiashader Sep 4, 2024
d2f83ca
Update nervous-badgers-count.md
nuke-ellington Sep 12, 2024
967f627
fix: naming
matthiashader Sep 12, 2024
a5d718f
chore: avoid shameful hoisting (#1471)
danielleroux Sep 18, 2024
21560ba
Merge branch 'release-3.0.0' into fix/1322-pane-layout
matthiashader Sep 18, 2024
dc06f90
fix: rename vrt and snapshot
matthiashader Sep 18, 2024
80c0504
chore(.npmrc): add eslint to public-hosting
danielleroux Sep 19, 2024
cc6091f
fix(core/menu-about): set index if selected is set on tab-item (#1469)
matthiashader Sep 19, 2024
24dbdee
docs(modal): adapted preview examples for angular modal (#1478)
matthiashader Sep 19, 2024
6041b3d
fix(core/modal): fires 2 events on closing (#1489)
matthiashader Sep 23, 2024
a0316f5
fix(core/dropdown): clean up disconnected dropdowns (#1483)
nuke-ellington Sep 23, 2024
c37edc0
Docs/uxt migration (#1426)
kathrinschalber Sep 24, 2024
aa641d5
refactor(docs): remove example-styles project (#1472)
danielleroux Sep 24, 2024
7f37165
fix(core/input): remove hover state from readonly and disabled varianโ€ฆ
matthiashader Sep 24, 2024
665469f
docs(uxt): move css to static folder
danielleroux Sep 25, 2024
2d17535
docs(panes): rename file to match structure
danielleroux Sep 30, 2024
99f35e1
ci(strict-check): add tsconfig strict check to pull requests (#1494)
danielleroux Oct 1, 2024
d201c55
refactor(core): reduce strict errors (#1488)
danielleroux Oct 2, 2024
c2879f6
docs: add dropdown items to angular blind-header-actions example (#1503)
cma5 Oct 7, 2024
393b51d
fix(core/upload): disable file browser if control is disabled (#1506)
danielleroux Oct 10, 2024
81cd31b
Docs/uxt migration improvements (#1502)
kathrinschalber Oct 14, 2024
ff99d8c
fix(core/icon-toggle-button): remove console.log (#1516)
h4de5 Oct 15, 2024
8c23806
Merge branch 'refs/heads/main' into fix/1322-pane-layout
matthiashader Oct 16, 2024
494bc44
Revert "Merge branch 'refs/heads/main' into fix/1322-pane-layout"
matthiashader Oct 16, 2024
84ebf83
Merge branch 'release-3.0.0' into fix/1322-pane-layout
matthiashader Oct 22, 2024
c3c7bbe
Merge branch 'release-3.0.0' into fix/1322-pane-layout
danielleroux Oct 23, 2024
a9a9769
fix: typing
matthiashader Oct 23, 2024
4c6fdc1
fix: typing
matthiashader Oct 23, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/nervous-badgers-count.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@siemens/ix': major
---

fix(core/pane-layout): remove absolute positioning
2 changes: 1 addition & 1 deletion packages/core/src/components/pane-layout/pane-layout.scss
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
:host {
@include ix-component;
display: flex;
position: absolute;
position: relative;
width: 100%;
height: 100%;

Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/components/pane-layout/pane-layout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import { matchBreakpoint } from '../utils/breakpoints';
shadow: true,
})
export class Panes {
@Element() hostElement: HTMLIxPaneLayoutElement;
@Element() hostElement!: HTMLIxPaneLayoutElement;

/**
* Choose the layout of the panes.
Expand Down
60 changes: 60 additions & 0 deletions packages/core/src/tests/panes/layout-responsive/index.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
<!--
SPDX-FileCopyrightText: 2024 Siemens AG

SPDX-License-Identifier: MIT
-->

<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8"/>
<meta
content="width=device-width, initial-scale=1.0, minimum-scale=1.0, maximum-scale=5.0"
name="viewport"
/>
<title>Stencil Component Starter</title>
</head>
<body style="width: 400px; height: 400px">
<ix-pane-layout
id="pane-layout"
variant="floating"
layout="full-horizontal"
borderless="true"
>
<ix-pane heading="Pane Left" slot="left" size="33%">
<p>This is the left pane.</p>
</ix-pane>
<ix-pane heading="Pane Top" slot="top" size="33%">
<p>This is the top pane.</p>
</ix-pane>
<ix-pane heading="Pane Right" slot="right" size="33%">
<p>This is the right pane.</p>
</ix-pane>
<ix-pane heading="Pane Bottom" slot="bottom" size="33%">
<p>This is the bottom pane.</p>
</ix-pane>

<div slot="content" style="display: flex; flex-direction: column;">
<ix-button id="toggle-variant" style="margin: 2.5rem">Toggle Variant</ix-button>
<ix-button id="toggle-layout" style="margin: 2.5rem">Toggle Layout</ix-button>
</div>
</ix-pane-layout>

<script>
const paneLayout = document.getElementById("pane-layout");
const buttonVariant = document.getElementById("toggle-variant");
const buttonLayout = document.getElementById("toggle-layout");

buttonVariant.addEventListener("click", () => {
const isInline = paneLayout.variant === 'inline'

paneLayout.variant = isInline ? 'floating' : 'inline'
paneLayout.borderless = isInline;
})
buttonLayout.addEventListener("click", () => {
paneLayout.layout = paneLayout.layout === "full-vertical" ? "full-horizontal" : "full-vertical"
})
</script>
<script src="http://127.0.0.1:8080/scripts/e2e/load-e2e-runtime.js"></script>
</body>
</html>
7 changes: 7 additions & 0 deletions packages/core/src/tests/panes/panes.e2e.ts
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,13 @@ test.describe('pane', () => {
await expect(page).toHaveScreenshot();
});

regressionTest('layout, inline, collapsed, relative', async ({ page }) => {
nuke-ellington marked this conversation as resolved.
Show resolved Hide resolved
await page.goto('panes/layout-responsive');
await page.waitForTimeout(1000);

await expect(page).toHaveScreenshot();
});

regressionTest(
'slot, correctly toggles while being collapsed through content click',
async ({ page }) => {
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading