Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove collectd/df monitor #3996

Merged
merged 1 commit into from
Jan 3, 2024
Merged

remove collectd/df monitor #3996

merged 1 commit into from
Jan 3, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Dec 1, 2023

Description:

This PR removes the collectd/df monitor. The monitor is deprecated and the filesystems monitor should be used instead. This component was deprecated 3 years 10 months ago.

Please see this deprecation notice on the filesystems monitor:

    ## Migrating from collectd/df
    The `collectd/df` monitor is being deprecated in favor of the `filesystems`
    monitor.  While the `collectd/df` monitor will still be available in
    5.0, it is recommended that you switch to the `filesystems` monitor soon
    after upgrading.  There are a few incompatibilities to be aware of between
    the two monitors:
     - `collectd/df` used a dimension called `plugin_instance` to identify the
       mount point or device of the filesystem.  This dimension is completely
       removed in the `filesystems` monitor and replaced by the `mountpoint`
       and `device` dimensions.  You no longer have to select between the two
       (the `reportByDevice` option on `collectd/df`) as both are always
       reported.
     - The mountpoints in the `plugin_instance` dimension of `collectd/df`
       were reported with `-` instead of the more conventional `/` separated
       path segments.  The `filesystems` monitor always reports mountpoints in
       the `mountpoint` dimension and uses the conventional `/` separator.
     - The `collectd/df` plugin set a dimension `plugin: df` on all datapoints,
       but `filesystems` has no such comparable dimension.

@atoulme atoulme requested review from a team as code owners December 1, 2023 05:13
Copy link
Contributor

@rmfitzpatrick rmfitzpatrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please replace w/ logged deprecation notice for at least a release

@atoulme atoulme merged commit 69d76e8 into main Jan 3, 2024
45 checks passed
@delete-merged-branch delete-merged-branch bot deleted the remove_collectd_df branch January 3, 2024 01:03
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants