Add routing processor to components #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
approved these changes
Nov 24, 2021
Comment on lines
+1883
to
+1884
| github.com/open-telemetry/opentelemetry-collector-contrib/exporter/jaegerexporter v0.39.0 h1:Rlo1LtOqL82WLvO1DbD4oxkGfHjpEba0qtFdphCHP1I= | ||
| github.com/open-telemetry/opentelemetry-collector-contrib/exporter/jaegerexporter v0.39.0/go.mod h1:rtWpnSnfT06AdQMPnqGDQP+X8qc8lkF6pHGPNsAW8/4= |
There was a problem hiding this comment.
Sad that we are bringing it because the routing processor use in one test case
There was a problem hiding this comment.
Not sure what the downside is, but there will surely be more needs here. And the alternative, recommending they build their own distro, isn't better for them or Splunk.
I do appreciate the quick action here!
There was a problem hiding this comment.
I'm talking just about jaegerexporter dependency brought by the routing processer where it's being used just in one test. Not a big deal but makes our build unnecessary bigger.
Adding the processor itself makes sense and LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #981