Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add routing processor to components #982

Merged
merged 1 commit into from
Nov 25, 2021
Merged

Add routing processor to components #982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/components.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ removed prior to the 1.0 release.
| [sapm](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/sapmreceiver) | [probabilisticsampler](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/processor/probabilisticsamplerprocessor) | | [zpages](https://github.com/open-telemetry/opentelemetry-collector/tree/main/extension/zpagesextension) |
| [signalfx](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/signalfxreceiver) | [resource](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/processor/resourceprocessor) | | |
| [simpleprometheus](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/simpleprometheusreceiver) | [resourcedetection](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/processor/resourcedetectionprocessor) | | |
| [smartagent](../internal/receiver/smartagentreceiver) | [span](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/processor/spanprocessor) | | |
| [splunk_hec](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/splunkhecreceiver) | | | |
| [smartagent](../internal/receiver/smartagentreceiver) | [routing](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/processor/routingprocessor) | | |
| [splunk_hec](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/splunkhecreceiver) | [span](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/processor/spanprocessor) | | |
| [zipkin](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/zipkinreceiver) | | | |

## Alpha
Expand Down
1 change: 1 addition & 0 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ require (
github.com/open-telemetry/opentelemetry-collector-contrib/processor/probabilisticsamplerprocessor v0.39.0
github.com/open-telemetry/opentelemetry-collector-contrib/processor/resourcedetectionprocessor v0.39.0
github.com/open-telemetry/opentelemetry-collector-contrib/processor/resourceprocessor v0.39.0
github.com/open-telemetry/opentelemetry-collector-contrib/processor/routingprocessor v0.39.0
github.com/open-telemetry/opentelemetry-collector-contrib/processor/spanprocessor v0.39.0
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/carbonreceiver v0.39.0
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/collectdreceiver v0.39.0
Expand Down
4 changes: 4 additions & 0 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1880,6 +1880,8 @@ github.com/onsi/gomega v1.16.0/go.mod h1:HnhC7FXeEQY45zxNK3PPoIUhzk/80Xly9PcubAl
github.com/op/go-logging v0.0.0-20160315200505-970db520ece7/go.mod h1:HzydrMdWErDVzsI23lYNej1Htcns9BCg93Dk0bBINWk=
github.com/open-telemetry/opentelemetry-collector-contrib/exporter/fileexporter v0.39.0 h1:PB7zyHwV6p+Z8z4MDcFzgBBHPMEd0rasNKK8c0bMC6o=
github.com/open-telemetry/opentelemetry-collector-contrib/exporter/fileexporter v0.39.0/go.mod h1:wJmDmp9OeDbaWWg18jhfjzvWSIxJfJWYKZ9R0izyiz0=
github.com/open-telemetry/opentelemetry-collector-contrib/exporter/jaegerexporter v0.39.0 h1:Rlo1LtOqL82WLvO1DbD4oxkGfHjpEba0qtFdphCHP1I=
github.com/open-telemetry/opentelemetry-collector-contrib/exporter/jaegerexporter v0.39.0/go.mod h1:rtWpnSnfT06AdQMPnqGDQP+X8qc8lkF6pHGPNsAW8/4=
Comment on lines +1883 to +1884
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sad that we are bringing it because the routing processor use in one test case

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what the downside is, but there will surely be more needs here. And the alternative, recommending they build their own distro, isn't better for them or Splunk.

I do appreciate the quick action here!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm talking just about jaegerexporter dependency brought by the routing processer where it's being used just in one test. Not a big deal but makes our build unnecessary bigger.

Adding the processor itself makes sense and LGTM

github.com/open-telemetry/opentelemetry-collector-contrib/exporter/kafkaexporter v0.39.0 h1:KeMjEH8l0yzL+40h5t+IAjNSKMZpCR0WhE/7zlkTLmI=
github.com/open-telemetry/opentelemetry-collector-contrib/exporter/kafkaexporter v0.39.0/go.mod h1:APFtCgkJuKdgnTP5en1x3cpuTc2VRrhgb+bXBUHc4ag=
github.com/open-telemetry/opentelemetry-collector-contrib/exporter/prometheusremotewriteexporter v0.39.0 h1:ZitSu/NdwEmqJXMIfGpFsnzF3LcOkPn3iETC0BlbY6U=
Expand Down Expand Up @@ -1949,6 +1951,8 @@ github.com/open-telemetry/opentelemetry-collector-contrib/processor/resourcedete
github.com/open-telemetry/opentelemetry-collector-contrib/processor/resourcedetectionprocessor v0.39.0/go.mod h1:8CvDnYMiRisb0bhMTNTmQEL4KdsujDUpY2wTv1TIIok=
github.com/open-telemetry/opentelemetry-collector-contrib/processor/resourceprocessor v0.39.0 h1:0qKcx7wdv6k2tOgF2EhdnDRzcK1nf196573ej6Cflrw=
github.com/open-telemetry/opentelemetry-collector-contrib/processor/resourceprocessor v0.39.0/go.mod h1:vBQuiaGp9fso5GBMQMHlG910lFQfLQDKmobfzwH7OT0=
github.com/open-telemetry/opentelemetry-collector-contrib/processor/routingprocessor v0.39.0 h1:lDSwPTreyHzYILQoGP4JPTZuTHwiPgeyxLwGCUJ1C6M=
github.com/open-telemetry/opentelemetry-collector-contrib/processor/routingprocessor v0.39.0/go.mod h1:nkO9trz2PzoasBKb7tSVehg4Mm1X0iQOADt4+P5PDHw=
github.com/open-telemetry/opentelemetry-collector-contrib/processor/spanprocessor v0.39.0 h1:VHqPcjoRATPUcpBxPJaOdJXt829+ss51HAGabUnGcIA=
github.com/open-telemetry/opentelemetry-collector-contrib/processor/spanprocessor v0.39.0/go.mod h1:VrRlIUW08Heajl3F3Ta6LrK46P8EUU1eEHTo31vYSA0=
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/carbonreceiver v0.39.0 h1:X4BTlF+G9d6eM+KtX6c3Qk+cRBLeawAXThYj9g4wGRU=
Expand Down
2 changes: 2 additions & 0 deletions internal/components/components.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ import (
"github.com/open-telemetry/opentelemetry-collector-contrib/processor/probabilisticsamplerprocessor"
"github.com/open-telemetry/opentelemetry-collector-contrib/processor/resourcedetectionprocessor"
"github.com/open-telemetry/opentelemetry-collector-contrib/processor/resourceprocessor"
"github.com/open-telemetry/opentelemetry-collector-contrib/processor/routingprocessor"
"github.com/open-telemetry/opentelemetry-collector-contrib/processor/spanprocessor"
"github.com/open-telemetry/opentelemetry-collector-contrib/receiver/carbonreceiver"
"github.com/open-telemetry/opentelemetry-collector-contrib/receiver/collectdreceiver"
Expand Down Expand Up @@ -143,6 +144,7 @@ func Get() (component.Factories, error) {
probabilisticsamplerprocessor.NewFactory(),
resourcedetectionprocessor.NewFactory(),
resourceprocessor.NewFactory(),
routingprocessor.NewFactory(),
spanprocessor.NewFactory(),
)
if err != nil {
Expand Down
1 change: 1 addition & 0 deletions internal/components/components_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ func TestDefaultComponents(t *testing.T) {
"probabilistic_sampler",
"resource",
"resourcedetection",
"routing",
"span",
}
expectedExporters := []config.Type{
Expand Down