Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix ganache windows CI attempt 2 #3107

Closed
wants to merge 3 commits into from

Conversation

realbigsean
Copy link
Member

@realbigsean realbigsean commented Mar 22, 2022

Issue Addressed

Attempt to fix CI

Proposed Changes

  • install node-gyp-build which should look for prebuilt binaries for @truffle-suite/bigint_buffer. This should make it so we don't have to build it directly. See: use new @trufflesuite/bigint-buffer trufflesuite/ganache#1414 this didn't work
  • This also uses the setup-node action because it includes caching. Sort of a shot in the dark, but the ganache github repo uses it and the failures seem to be for missing files in a node cache

Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it.

If this doesn't work I reckon we go the Docker route.

@michaelsproul michaelsproul added the ready-for-merge This PR is ready to merge. label Mar 22, 2022
@michaelsproul
Copy link
Member

bors r+

@bors
Copy link

bors bot commented Mar 22, 2022

🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@michaelsproul
Copy link
Member

Re-run license CLA

@michaelsproul
Copy link
Member

bors retry

bors bot pushed a commit that referenced this pull request Mar 22, 2022
## Issue Addressed

Attempt to fix CI

## Proposed Changes

- ~~install `node-gyp-build` which should look for prebuilt binaries for `@truffle-suite/bigint_buffer`. This should make it so we don't have to build it directly. See: trufflesuite/ganache#1414 this didn't work
- This also uses the `setup-node` action because it includes caching. Sort of a shot in the dark, but the ganache github repo uses it and the failures seem to be for missing files in a node cache 




Co-authored-by: realbigsean <[email protected]>
@bors bors bot changed the title Fix ganache windows CI attempt 2 [Merged by Bors] - Fix ganache windows CI attempt 2 Mar 22, 2022
@bors bors bot closed this Mar 22, 2022
paulhauner pushed a commit to paulhauner/lighthouse that referenced this pull request May 6, 2022
## Issue Addressed

Attempt to fix CI

## Proposed Changes

- ~~install `node-gyp-build` which should look for prebuilt binaries for `@truffle-suite/bigint_buffer`. This should make it so we don't have to build it directly. See: trufflesuite/ganache#1414 this didn't work
- This also uses the `setup-node` action because it includes caching. Sort of a shot in the dark, but the ganache github repo uses it and the failures seem to be for missing files in a node cache 




Co-authored-by: realbigsean <[email protected]>
@realbigsean realbigsean deleted the node-gyp-build branch November 21, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants