This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
use new @trufflesuite/bigint-buffer #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmurdoch
suggested changes
Nov 1, 2021
Co-authored-by: David Murdoch <[email protected]>
MicaiahReid
commented
Nov 1, 2021
davidmurdoch
approved these changes
Nov 3, 2021
Merged
bors bot
pushed a commit
to sigp/lighthouse
that referenced
this pull request
Mar 22, 2022
## Issue Addressed Attempt to fix CI ## Proposed Changes - ~~install `node-gyp-build` which should look for prebuilt binaries for `@truffle-suite/bigint_buffer`. This should make it so we don't have to build it directly. See: trufflesuite/ganache#1414 this didn't work - This also uses the `setup-node` action because it includes caching. Sort of a shot in the dark, but the ganache github repo uses it and the failures seem to be for missing files in a node cache Co-authored-by: realbigsean <[email protected]>
paulhauner
pushed a commit
to paulhauner/lighthouse
that referenced
this pull request
May 6, 2022
## Issue Addressed Attempt to fix CI ## Proposed Changes - ~~install `node-gyp-build` which should look for prebuilt binaries for `@truffle-suite/bigint_buffer`. This should make it so we don't have to build it directly. See: trufflesuite/ganache#1414 this didn't work - This also uses the `setup-node` action because it includes caching. Sort of a shot in the dark, but the ganache github repo uses it and the failures seem to be for missing files in a node cache Co-authored-by: realbigsean <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the bigint-buffer library used by Ganache would fail to build on Windows unless
windows-build-toolswas installed. This would cause the (slower) JS fallback to be used and would display an ugly warning in the console on startup of Ganache. This PR's main objective is to use trufflesuite's new bigint-buffer library, which prebuilds all binaries during CI to prevent this warning.Additionally, this PR:
Closes #1080