Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI nethermind and LLVM versions #5933

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Conversation

jimmygchen
Copy link
Member

Issue Addressed

Update nethermind and LLVM versions.

  • Rust 1.79 updates the minimum external LLVM to 17. Note we no longer use GitHub hosted runners for release and I think our windows runners use latest version. (FYI @antondlr in case if we run into any issues)
  • Update Nethermind version to latest release.

@jimmygchen jimmygchen added ready-for-review The code is ready for review infra-ci labels Jun 17, 2024
@jimmygchen
Copy link
Member Author

Requires installing dotnet8 on the self-hosted runners.

@jimmygchen jimmygchen added the low-hanging-fruit Easy to resolve, get it before someone else does! label Jun 18, 2024
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jun 19, 2024
@jimmygchen
Copy link
Member Author

@mergify queue

Copy link

mergify bot commented Jun 19, 2024

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@jimmygchen
Copy link
Member Author

@mergify requeue

Copy link

mergify bot commented Jun 19, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

Copy link

mergify bot commented Jun 19, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 9f8aa96

mergify bot added a commit that referenced this pull request Jun 19, 2024
@mergify mergify bot merged commit 9f8aa96 into sigp:unstable Jun 19, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra-ci low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants