You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous method was indexing the blob_bytes on i * BYTES_PER_FIELD_ELEMENT -- this method iterates the blob_bytes directly and skips to every BYTES_PER_FIELD_ELEMENT so we can avoid the failure modes:
Index out of bounds is no longer possible since the iterator will just stop iterating at that point
Checked mul can also be avoided
Proposed Changes
Please list or describe the changes introduced by this PR.
Additional Info
Please provide any additional information. For example, future considerations
or information useful for reviewers.
🛑 The pull request has been removed from the queue default
The queue conditions cannot be satisfied due to failing checks.
You can take a look at Queue: Embarked in merge queue check runs for more details.
In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment @mergifyio refresh on the pull request.
🛑 The pull request has been removed from the queue default
Pull request #5946 has been dequeued by a dequeue command.
You can take a look at Queue: Embarked in merge queue check runs for more details.
In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment @mergifyio refresh on the pull request.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jimmygchen
added
test improvement
Issue Addressed
The previous method was indexing the blob_bytes on
i * BYTES_PER_FIELD_ELEMENT-- this method iterates the blob_bytes directly and skips to everyBYTES_PER_FIELD_ELEMENTso we can avoid the failure modes:Proposed Changes
Please list or describe the changes introduced by this PR.
Additional Info
Please provide any additional information. For example, future considerations
or information useful for reviewers.